New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726942 link

Starred by 1 user
Status: Archived
Owner:
khmel@chromium.org
Closed: May 2017
Cc:
█ dskaram@chromium.org
█ josa...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: CrossOver has default icon on shelf

Project Member Reported by khmel@chromium.org, May 26 2017 
Repro:

Install  CrossOver app, for example Notepad++
Make sure that app is created in app launcher.
Now run this app. Default app icon is created on the shelf.

It is expected that icon is the same as in app launcher.

Comment 1 by khmel@chromium.org, May 27 2017

Cc: dskaram@chromium.org
Components: Platform>ARC
Labels: -Pri-3 OS-Chrome Pri-1

Comment 2 by dskaram@chromium.org, May 29 2017

Labels: M-60
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3eb6c571952013b977aeeab568163c321617a7b

commit c3eb6c571952013b977aeeab568163c321617a7b
Author: khmel <khmel@google.com>
Date: Tue May 30 17:47:48 2017

arc: Fix default app icon for CrossOver app.

This CL fixes icon mapping from CrossOver app to shortcut.

TEST=Manually + test updated.
BUG= 726942 
BUG=b/62145028

Change-Id: Ia6bed938cc1ccdb9155d0f88d76f3ed564442330
Reviewed-on: https://chromium-review.googlesource.com/517395
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475586}
[modify] https://crrev.com/c3eb6c571952013b977aeeab568163c321617a7b/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/c3eb6c571952013b977aeeab568163c321617a7b/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/c3eb6c571952013b977aeeab568163c321617a7b/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Comment 4 by khmel@chromium.org, May 30 2017

Cc: josa...@chromium.org
Labels: Merge-Request-60

Comment 5 by josa...@chromium.org, May 31 2017

Labels: -Merge-Request-60 Merge-Approved-60
Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65b97215d37ac6149877dc6f82db86309658bace

commit 65b97215d37ac6149877dc6f82db86309658bace
Author: khmel <khmel@chromium.org>
Date: Wed May 31 23:25:58 2017

[Merge M60] arc: Fix default app icon for CrossOver app.

This CL fixes icon mapping from CrossOver app to shortcut.

TEST=Manually + test updated.
BUG= 726942 
BUG=b/62145028

TBR=xiyuan@chromium.org
NOTRY=true
NOPRESUBMIT=true

Change-Id: Ia6bed938cc1ccdb9155d0f88d76f3ed564442330
Reviewed-on: https://chromium-review.googlesource.com/517395
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#475586}
Review-Url: https://codereview.chromium.org/2918723002
Cr-Commit-Position: refs/branch-heads/3112@{#69}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/65b97215d37ac6149877dc6f82db86309658bace/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/65b97215d37ac6149877dc6f82db86309658bace/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/65b97215d37ac6149877dc6f82db86309658bace/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Comment 7 by khmel@chromium.org, May 31 2017

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment