New issue
Advanced search Search tips

Issue 726927 link

Starred by 1 user
Status: Fixed
Owner:
creis@chromium.org
Closed: Jun 2018
Cc:
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Since --isolate-extensions shipped, we might be able to tighten ...ExtensionsPart::CanCommitURL

Project Member Reported by lukasza@chromium.org, May 26 2017 
One attempt at doing this is @ https://codereview.chromium.org/2909753002/patch/1/10001, but it currently fails quite a few tests:

ChromeSecurityExploitBrowserTest.ChromeExtensionResources
DevToolsExperimentalExtensionTest.TestDevToolsExperimentalExtensionAPI
DevToolsExtensionTest.DevToolsExtensionInDevToolsExtension
DevToolsExtensionTest.DevToolsExtensionInItself
DevToolsExtensionTest.DevToolsExtensionSecurityPolicyGrants
DevToolsExtensionTest.HttpIframeInDevToolsExtensionDevtools
DevToolsExtensionTest.HttpIframeInDevToolsExtensionPanel
DevToolsExtensionTest.HttpIframeInDevToolsExtensionSideBarPane
DevToolsExtensionTest.NonDevToolsExtensionInDevToolsExtension
DevToolsExtensionTest.TestDevToolsExtensionAPI
DevToolsExtensionTest.TestDevToolsExtensionMessaging
ExtensionLoadingTest.RuntimeValidWhileDevToolsOpen
ProcessManagementTest.NavigateToBlockedExtensionPageInNewTab
WebViewGuestTouchFocusTest.TouchFocusesBrowserPluginInEmbedder
WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/0
WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/1
WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/2
WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/3
WebViewScrollGuestContent/WebViewScrollGuestContentTest.ScrollGuestContent/0
WebViewTests/WebViewFocusTest.TouchFocusesEmbedder/0
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/0
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/1
WebViewTests/WebViewTest.AcceptTouchEvents/0
WebViewTests/WebViewTest.BlobInWebviewAccessibleResource/0
WebViewTests/WebViewTest.BlobInWebviewAccessibleResource/1
WebViewTests/WebViewTest.ContextMenuNavigationInMimeHandlerView/0
WebViewTests/WebViewTest.ContextMenuNavigationInMimeHandlerView/1
WebViewTests/WebViewTest.LoadWebviewInaccessibleResource/0
WebViewTests/WebViewTest.LoadWebviewInaccessibleResource/1
WebViewTests/WebViewTest.NestedGuestContainerBounds/0
WebViewTests/WebViewTest.NestedGuestContainerBounds/1
WebViewTests/WebViewTest.ReloadWebviewAccessibleResource/0
WebViewTests/WebViewTest.ReloadWebviewAccessibleResource/1
WebViewTests/WebViewTest.Shim_TestBlobURL/0
WebViewTests/WebViewTest.Shim_TestBlobURL/1
WebViewTests/WebViewTest.Shim_TestChromeExtensionRelativePath/0
WebViewTests/WebViewTest.Shim_TestChromeExtensionRelativePath/1
WebViewTests/WebViewTest.Shim_TestChromeExtensionURL/0
WebViewTests/WebViewTest.Shim_TestChromeExtensionURL/1
WebViewTests/WebViewTest.Shim_TestInlineScriptFromAccessibleResources/0
WebViewTests/WebViewTest.Shim_TestInlineScriptFromAccessibleResources/1
WebViewTests/WebViewTest.Shim_TestNestedSubframes/0
WebViewTests/WebViewTest.Shim_TestNestedSubframes/1

FWIW, in my manual testing I didn't see any negative effects of the attempt above on spanning-incognito-extensions (see  issue 691145 ).
Project Member

Comment 1 by sheriffbot@chromium.org, May 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by nasko@chromium.org, Jun 28 2018

Labels: -Hotlist-Recharge-Cold
Owner: creis@chromium.org
I think creis@ has landed more or less the spirit of this bug in r567799. Close as Fixed maybe?

Comment 3 by creis@chromium.org, Jun 28 2018

Status: Fixed (was: Untriaged)
Yep!  Should have listed this bug on that CL as well, in addition to  issue 770239  and  issue 840857 .  Thanks for spotting it.
►

Sign in to add a comment