New issue
Advanced search Search tips

Issue 726926 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: leaky styles from new Audits panel affect other toolbars

Project Member Reported by l...@chromium.org, May 26 2017 
What steps will reproduce the problem?
(1) Open DevTools, go to the new Audits panel
(2) Switch to Elements
(3) Observe the :hov :cls + buttons in styles sidebar pane

What is the expected result?
No border bottom

What happens instead?
Border bottom shows up
leakyToolbarStyle.png
23.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb9004bf71f341d4a072f4d83ef3431a36e31250

commit fb9004bf71f341d4a072f4d83ef3431a36e31250
Author: luoe <luoe@chromium.org>
Date: Sat May 27 04:20:51 2017

DevTools: stop hideOnDetach for Audits

The new Audits panel calls hideOnDetach. This allows iframes within to run
uninterrupted when switching to another panel. An unwanted side effect of
keeping it in the DOM is that its stylesheets will apply to other panels.

Today, Audits no longer has iframes inside, so this is not needed anymore.

BUG= 726926 

Review-Url: https://codereview.chromium.org/2906853004
Cr-Commit-Position: refs/heads/master@{#475235}

[modify] https://crrev.com/fb9004bf71f341d4a072f4d83ef3431a36e31250/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

Comment 2 by l...@chromium.org, Jun 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment