New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726914 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO - please don't assign
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chromium Dash Feedback - Legend on the SLO violations graph

Project Member Reported by sshru...@google.com, May 26 2017

Issue description

Triage query returns SLO violations, but the P0/P1 and regressions don't exactly, so we had decided to only call out the triage ones as SLOs since that one is pretty clear, and show P0/P1s and regression numbers as well on the side, but not call them SLO violations. But the graph still calls them SLO violations. If the graph is the same as the numbers, could we please have the graph use the same names as the table?
 
Owner: sshruthi@chromium.org
Status: Assigned (was: Unassigned)
sshruthi@, can you help me understand what you mean by "triage query" here?  Even if they don't line up with the items in the tabular data (which is what I'm assuming you mean here) the items in the graph are SLO based on the criteria I think you had provided - see https://chrome-internal.googlesource.com/infra/infra_internal/+/master/appengine/chromiumdash/models/component_stats.py#58 and https://chrome-internal.googlesource.com/infra/infra_internal/+/master/appengine/chromiumdash/models/component_stats.py#89

Is that not what you are looking for?

Comment 2 by sshru...@google.com, May 30 2017

Owner: amineer@chromium.org
As per the SLO doc (go/web-platform-slos), we don't have an SLO for all regressions for instance. And, the column names reflects that (only triage has the word SLO, other two columns don't), but in the graph, all of them have the word SLO attached to them. Happy to chat in person, since this is a bit of a nit, and a little confusing to explain without using the view as an aid.
Owner: sshruthi@chromium.org
I see.  So we *do* have an SLO for Pri=0,1, we *do not* have an SLO for regressions.  So we're saying we should delete this entry from our config?  https://chrome-internal.googlesource.com/infra/infra_internal/+/master/appengine/chromiumdash/models/component_stats.py#89

Can you confirm that the Pri=0,1 SLO is correct?  https://chrome-internal.googlesource.com/infra/infra_internal/+/master/appengine/chromiumdash/models/component_stats.py#58

And really if you can go over the rest of the entries there and ensure we have something for everything you'd expect, and we don't have anything that you think is incompatible with the Blink team's practices, it would be appreciated.

Once you confirm we're capturing what you want, we can discuss labeling / graph content / whatever - that's easy once what we are capturing is finalized.

Comment 4 by sshru...@google.com, May 30 2017

We don't need to delete anything, in terms of the data we are capturing. The data table columns are titled "Pri 0/1", "Regression" and "Triage SLO", but the legend in the graph above has the word "SLO" on all three. I would like the graph legend to reflect the wording of the columns in the data table. As I said before, this is merely a nit, not a major change request. :) Let me know if that makes sense.
Labels: Dashboard-Polish
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 14 2017

Labels: Hotlist-Google
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/7b430cc53247d63aa90777eb590f27d3507807b8

commit 7b430cc53247d63aa90777eb590f27d3507807b8
Author: Alex Mineer <amineer@google.com>
Date: Mon Jul 17 19:44:46 2017

Status: Fixed (was: Assigned)
Marking this as fixed since "Regression SLO" has been removed from the staging instance data model and we won't graph it.

Note the current deployed instance will still show it until we cut over to the new version, so it'll still be there for a little while.

Sign in to add a comment