New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726911 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

toolchain packages (e.g. glibc) not included in OS credits page or CPE list

Project Member Reported by andreyu@google.com, May 26 2017

Issue description

Chrome Version: R60
OS: ChromiumOS

When looking at the following two files:

1. about_os_credits.htm (included in image in /opt/google/chrome/resources/about_os_credits.htm) 
2. list of CPEs (which is save in build artifacts directory as cpe-chromeos-<board>.json)

we noticed that neither includes sys-libs/glibc. Both files are generated from package dependency graph.
 

Comment 1 by vapier@chromium.org, May 27 2017

Components: Infra>Client>ChromeOS OS>Systems
Labels: Build-Toolchain
Status: Available (was: Untriaged)
Summary: toolchain packages (e.g. glibc) not included in OS credits page or CPE list (was: glibc is not included in OS credits page or CPE list)
hmm we could be lazy and add a stub glibc package that'd have the same metadata.xml that'd get emerged into the sysroot.  but we'd have to hand maintain the version in the ebuilds.

we have install_toolchain which takes care of syncing all the relevant packages & versions when setting up a new sysroot.  we could have it inject details into a special location that the chromite licensing processing would pick up.

none of these are great options :/.
Owner: yunlian@chromium.org
yunlian, could you find the easiest way to do this? 
In the ~/trunk/chromite/licensing/licenses command, it runs

  /build/terra/build/bin/emerge '--with-bdeps=y' --usepkgonly --emptytree --pretend '--color=n' virtual/target-os

to find out the packages installed for the target, and glibc is not in the list.
Is it because glibc is in
/build/terra/etc/portage/profile/package.provided ?

Comment 4 by vapier@chromium.org, Jun 21 2017

more or less.  we'll need to manually account for all packages we inject via src/scripts/install_toolchain.

Comment 5 by andreyu@google.com, Jul 5 2017

Any updates on this?
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 14 2017

Labels: Hotlist-Google

Comment 7 by xueweiz@google.com, Sep 12 2017

yunlian, vapier,

I looked inside src/scripts/install_toolchain, it seems that this script will inject version info about gcc + glibc + go into /build/terra/etc/portage/profile/package.provided.
But I can only find the code installing glibc, not gcc/golang. Is that how it's supposed to be? If so, which script will install gcc and go? Thanks!

Comment 8 by vapier@chromium.org, Sep 12 2017

we don't install gcc or go into the target

for gcc, we have the gcc-libs package.  go gets statically linked.

Comment 9 by xueweiz@google.com, Sep 15 2017

yunlian, vapier,

I made a change in cros_extract_deps to make it pick up SDK packages' CPEs. I manually tested it and it looks fine. Now I'm running trybot on it with lakitu-incremental. Could you suggest a few other config I should run? Thanks!

https://chromium-review.googlesource.com/c/chromiumos/chromite/+/669947
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/incremental/builds/618

Comment 10 by xueweiz@google.com, Sep 16 2017

update: trybot succeeded on lakitu-incremental. Found glibc CPE in artifact.

link:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/incremental/builds/618
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/656f993d5f47f969cf8ca7539304518d82af9761

commit 656f993d5f47f969cf8ca7539304518d82af9761
Author: Xuewei Zhang <xueweiz@google.com>
Date: Tue Sep 26 20:36:17 2017

Track CPEs for SDK packages in package.provided

BUG=b:62104917,  chromium:726911 
TEST=Trybot on lakitu-incremental passed. Found CPE of glibc in artifacts.

Change-Id: I06b89cd18705c2ec1894a9c304c21e9e1ca52b4f
Reviewed-on: https://chromium-review.googlesource.com/669947
Commit-Ready: Xuewei Zhang <xueweiz@google.com>
Tested-by: Xuewei Zhang <xueweiz@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/656f993d5f47f969cf8ca7539304518d82af9761/scripts/cros_extract_deps.py

Status: Fixed (was: Available)
i believe this is resolved now
Components: -Infra>Client>ChromeOS

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 15 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment