New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726902 link

Starred by 4 users

Issue metadata

Status: Duplicate
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-2.6% regression in memory.top_10_mobile at 474308:474371

Project Member Reported by briander...@chromium.org, May 26 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=726902

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-t6ZtQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-tjrpgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-ueAuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-t6DrAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-t6DrAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-ofYoQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-r-XsAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-q68vwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-vmkowsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-qyB_goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguoOhuQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-taLqQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-tLq7AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2tPrgQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg2tPr_gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-rmoiAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-srDuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-sy9qwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-qiT4wsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-vC95AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-vC9pAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgutvqvAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgusuh7wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgus_NogsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-rb4pQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-ubIoAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguuGrvQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguuaB5woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgus-mrAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguubaugkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-rb4pQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguqb9vAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguqG5_ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-rDwsgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguq_ypgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgurr5lwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-orRugoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDguoHe8AoM


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 27 2017

Cc: fdoray@chromium.org
Owner: fdoray@chromium.org

=== Auto-CCing suspected CL author fdoray@chromium.org ===

Hi fdoray@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : fdoray
  Commit : b87bcfb8c3b17bbcad020186a94e935e2fd0d162
  Date   : Wed May 24 17:49:40 2017
  Subject: [reland] Use TaskScheduler instead of WorkerPool in v8_platform.cc.

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:malloc:effective_size_avg/foreground/https_mobile_twitter_com_justinbieber_skip_interstitial_true
  Change       : 3.36% | 34825724.6667 -> 35995280.6667

Revision             Result                   N
chromium@474307      34825725 +- 828837       6       good
chromium@474329      34557769 +- 1522731      6       good
chromium@474340      34375066 +- 862268       6       good
chromium@474345      34719231 +- 1112988      9       good
chromium@474346      35359453 +- 1421513      14      bad       <--
chromium@474347      35412229 +- 930499       9       bad
chromium@474348      35681125 +- 961284       6       bad
chromium@474350      35995281 +- 650439       6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8978491213402589728

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6132109212647424


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, May 28 2017

Issue 726899 has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 30 2017

Cc: toyoshim@chromium.org
 Issue 727480  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, May 30 2017

Cc: jgruber@chromium.org
 Issue 727663  has been merged into this issue.
Issue 727509 has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jun 13 2017

 Issue 726903  has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jun 13 2017

 Issue 726903  has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jun 13 2017

 Issue 726922  has been merged into this issue.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Jun 16 2017

Cc: tebbi@chromium.org
 Issue 734032  has been merged into this issue.
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Jun 20 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile
  Metric       : v8-gc-total_max/browse_media/browse_media_imgur
  Change       : 54.15% | 68.537 -> 35.9456666667

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/chromium/src/+log/168444cf44dfed8b347a5fbaf4420a6733e11e2d..6eb5c1eb647e1709b4b03ae5148f8c03daea03fb


Revision             Result                  N
chromium@474752      68.537 +- 88.3777       14       good
chromium@474760      65.3543 +- 73.7399      14       good
chromium@474761      ---                     ---      build failure
chromium@474762      40.3543 +- 33.8716      14       bad
chromium@474763      40.2683 +- 27.486       9        bad
chromium@474766      39.7714 +- 24.0455      14       bad
chromium@474779      41.032 +- 14.8082       9        bad
chromium@474805      31.1821 +- 20.1591      9        bad
chromium@474857      35.9457 +- 14.7867      9        bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur v8.runtimestats.browsing_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976260272144400816

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5801742517665792


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Jun 20 2017

Mergedinto: 727588
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : fdoray
  Commit : 6eb5c1eb647e1709b4b03ae5148f8c03daea03fb
  Date   : Thu May 25 19:51:13 2017
  Subject: Update TaskTraits in v8_platform.cc.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile
  Metric       : v8-gc-total_max/browse_media/browse_media_imgur
  Change       : 47.23% | 60.4248571429 -> 31.8863571429

Revision             Result                  N
chromium@474752      60.4249 +- 93.8387      14      good
chromium@474759      78.523 +- 31.7173       6       good
chromium@474761      60.3803 +- 35.1906      6       good
chromium@474762      34.6617 +- 12.0309      6       bad       <--
chromium@474766      31.7456 +- 27.8149      14      bad
chromium@474780      36.5483 +- 40.601       21      bad
chromium@474805      35.81 +- 40.5049        21      bad
chromium@474857      31.8864 +- 27.0109      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur v8.runtimestats.browsing_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976260279720539376

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5241812463124480


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Sign in to add a comment