New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726889 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
(currently inactive on Chromium)
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Disable back button when stack is empty

Project Member Reported by ymalik@chromium.org, May 26 2017

Issue description

The back button is still enabled when there's nothing to go back to. We should probably disable it in this case.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed4df89fed450d8f2741bba7cd2651ad28c6a779

commit ed4df89fed450d8f2741bba7cd2651ad28c6a779
Author: ymalik <ymalik@chromium.org>
Date: Mon May 29 19:37:10 2017

Disable back button when stack is empty

If the back stack is empty
- The back button icon's color is that of the foreground with an alpha of 0x33
- Hovering over the back button doesn't change its color

Note:
- tested manually due to time constraints, but we should add a tests

BUG= 726889 

Review-Url: https://codereview.chromium.org/2906403002
Cr-Commit-Position: refs/heads/master@{#475375}

[modify] https://crrev.com/ed4df89fed450d8f2741bba7cd2651ad28c6a779/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/ed4df89fed450d8f2741bba7cd2651ad28c6a779/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/ed4df89fed450d8f2741bba7cd2651ad28c6a779/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/ed4df89fed450d8f2741bba7cd2651ad28c6a779/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/ed4df89fed450d8f2741bba7cd2651ad28c6a779/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/ed4df89fed450d8f2741bba7cd2651ad28c6a779/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/ed4df89fed450d8f2741bba7cd2651ad28c6a779/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/ed4df89fed450d8f2741bba7cd2651ad28c6a779/chrome/browser/android/vr_shell/vr_gl_thread.cc

Comment 2 by ymalik@chromium.org, May 29 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, May 29 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8cc130f7fa4718d1656d00276f3303ce48e9393

commit e8cc130f7fa4718d1656d00276f3303ce48e9393
Author: Ian Vollick <vollick@chromium.org>
Date: Tue May 30 12:53:45 2017

Disable back button when stack is empty

If the back stack is empty
- The back button icon's color is that of the foreground with an alpha of 0x33
- Hovering over the back button doesn't change its color

Note:
- tested manually due to time constraints, but we should add a tests

BUG= 726889 

Review-Url: https://codereview.chromium.org/2906403002
Cr-Original-Commit-Position: refs/heads/master@{#475375}
Review-Url: https://codereview.chromium.org/2912953002 .
Cr-Commit-Position: refs/branch-heads/3112@{#26}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/e8cc130f7fa4718d1656d00276f3303ce48e9393/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/e8cc130f7fa4718d1656d00276f3303ce48e9393/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/e8cc130f7fa4718d1656d00276f3303ce48e9393/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/e8cc130f7fa4718d1656d00276f3303ce48e9393/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/e8cc130f7fa4718d1656d00276f3303ce48e9393/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/e8cc130f7fa4718d1656d00276f3303ce48e9393/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/e8cc130f7fa4718d1656d00276f3303ce48e9393/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/e8cc130f7fa4718d1656d00276f3303ce48e9393/chrome/browser/android/vr_shell/vr_gl_thread.cc

Comment 5 by ymalik@chromium.org, May 31 2017

Status: Fixed (was: Available)
Labels: needs
Note that the back button isn't returning to the active state UI when the stack is re-filled. Functionality works, but it keeps it's disabled look. crbug 728435 was logged for this.
Labels: -needs
Labels: Proj-VR-Shell
Status: Verified (was: Fixed)
Verified in chrome Canary 61.0.3124.3
I'm not sure if this is the same issue resurfacing, but I logged a new bug on the same issue. bug 735143

Sign in to add a comment