New issue
Advanced search Search tips

Issue 726870 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Unable to upload patch for skia

Project Member Reported by danakj@chromium.org, May 26 2017

Issue description

1. fetch skia
2. commit changes
3. git cl upload

Credentials for the following hosts are required:
  skia.googlesource.com
These are read from /usr/local/google/home/danakj/.gitcookies (or legacy /usr/local/google/home/danakj/.netrc)
You can (re)generate your credentials by visiting https://skia-review.googlesource.com/new-password


I have visited the URL, made credentials, placed them in my .gitcookies, but the error remains.
 

Comment 1 by danakj@chromium.org, May 26 2017

My .gitcookies has something like:

skia.googlesource.com                   FALSE   /       TRUE    2147483647      o       git-danakj.chromium.org=1/abcdefghijklmnopqrstuvwxyz
skia-review.googlesource.com            FALSE   /       TRUE    2147483647      o       git-danakj.chromium.org=1/abcdefghijklmnopqrstuvwxyz


That's weird.  This looks fine to me.  Sometimes I need to comment out all but one of my .gitcookies?

Have you tried a manual upload,

   git push origin @:refs/for/master

?

Comment 3 by danakj@chromium.org, May 26 2017

I tried removing all the cookies but the skia one and/or the skia-review one without luck.

>    git push origin @:refs/for/master

Counting objects: 5, done.
Delta compression using up to 48 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 736 bytes | 0 bytes/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done    
remote: ERROR: [5d83a8e] missing Change-Id in commit message footer
remote: 
remote: Hint: To automatically insert Change-Id, install the hook:
remote: curl -Lo `git rev-parse --git-dir`/hooks/commit-msg https://gerrit-review.googlesource.com/tools/hooks/commit-msg ; chmod +x `git rev-parse --git-dir`/hooks/commit-msg
remote: And then amend the commit:
remote:   git commit --amend
remote: 
To https://skia.googlesource.com/skia.git
 ! [remote rejected]       @ -> refs/for/master ([5d83a8e] missing Change-Id in commit message footer)
error: failed to push some refs to 'https://skia.googlesource.com/skia.git'


At which point I am very worried about what I'm doing cuz Change-Id should be when landing right? x.x

Comment 4 by danakj@chromium.org, May 26 2017

Status: WontFix (was: Untriaged)
It seems that the tr magic, or the copy pasting, did something weird, and I ended up with 2 tabs between the hostname and the rest, which made it not work. git cl creds-check pointed out they were missing which helped me find it.

Sign in to add a comment