Revert on Gerrit has no title and has no flags like NOTRY |
||||
Issue descriptionFor a revert created by Findit on Gerrit, it looks like https://chromium-review.googlesource.com/c/509071/ However, a manually-created one of the same culprit looks like https://chromium-review.googlesource.com/c/509329 Findit should have do the same on including original description and those flags like NOTRY/etc.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/36e9683030c5ab08219c5d8d216b84ec2a7fb83b commit 36e9683030c5ab08219c5d8d216b84ec2a7fb83b Author: Chan <chanli@chromium.org> Date: Fri Jun 02 18:41:13 2017 Store CL subject and description in cl_info. In preparation of adding original CL's info to revert CL's description. Bug:726841 Change-Id: Iedb2f198015c2d001ad1e6faf483453a31c40ead Reviewed-on: https://chromium-review.googlesource.com/521303 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/36e9683030c5ab08219c5d8d216b84ec2a7fb83b/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py [modify] https://crrev.com/36e9683030c5ab08219c5d8d216b84ec2a7fb83b/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py [modify] https://crrev.com/36e9683030c5ab08219c5d8d216b84ec2a7fb83b/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/36e9683030c5ab08219c5d8d216b84ec2a7fb83b/appengine/findit/infra_api_clients/codereview/cl_info.py
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/acfd53ec93bbb914556854064e238426a768f796 commit acfd53ec93bbb914556854064e238426a768f796 Author: Chan <chanli@chromium.org> Date: Fri Jun 02 20:04:07 2017 Include original CL's information in revert CL's description. The revert CL's description would include: 1. original CL subject if exists 2. original CL commit revision 3. revised original CL description (add '> ' at the beginning of each line) 4. skip CQ flags if revert is within one day, otherwise an explanation about why don't skip CQ. 5. original CL's bug id if any 6. original CL's cq inclue try bots if any Bug:726841 Change-Id: I518e5a6352316d806005d65d0e6bfb073a8fd4a9 Reviewed-on: https://chromium-review.googlesource.com/521748 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/acfd53ec93bbb914556854064e238426a768f796/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/acfd53ec93bbb914556854064e238426a768f796/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
,
Jun 2 2017
,
Jun 15 2017
I found https://chromium-review.googlesource.com/c/536196/ and it looks like the title and description is still not working. reopen the issue.
,
Jun 15 2017
You may check whether the fix was in the default version or not. OK, as you spot that CL, please follow up. Especially the second concern on reviewer list.
,
Jun 15 2017
That reviewer list feedback might worth another bug though.
,
Jun 15 2017
I think you're right, this change is not in prod. I'll mark it back to fixed and verify it later. And open a new bug for reviewer list.
,
Jun 15 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by chanli@chromium.org
, May 30 2017