Support the new launcher UX and launcher drag handling in mustash |
|||||||||||
Issue descriptionSupport the new launcher UX and launcher drag handling in mustash once we meet the 61 deadline.
,
May 26 2017
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22cab559bffd46a5be3bd2a547dbaa6be757fe9c commit 22cab559bffd46a5be3bd2a547dbaa6be757fe9c Author: Scott Violet <sky@chromium.org> Date: Thu Jun 29 00:52:56 2017 chromeos: enable AppListPresenterDelegateTests for mushrome These tests work fine in mushrome, so enabling them. BUG= 726838 TEST=none TBR=newcomer@chromium.org Change-Id: Ifa8903bc5a183c73e320060ca5dfeb5f20b4d5da Reviewed-on: https://chromium-review.googlesource.com/553448 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#483235} [modify] https://crrev.com/22cab559bffd46a5be3bd2a547dbaa6be757fe9c/testing/buildbot/filters/ash_unittests_mus.filter
,
Jul 1 2017
The NextAction date has arrived: 2017-07-01
,
Sep 8 2017
,
Oct 14 2017
,
Oct 16 2017
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5 commit d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5 Author: James Cook <jamescook@chromium.org> Date: Fri Dec 08 00:53:39 2017 cros: Clean up mash early-exits in ash_unittests --mash Our policy for mash is to disable via filter file unless the test is never expected to work under mash. Also re-enable a bunch of tests that now pass under mash, likely due to the display manager work done several months ago. Bug: 695556, 696752 , 698024 , 696006 , 581462 , 698129 , 726838 Test: ash_unittests for classic, --mus and --mash Change-Id: Ia192d77b107c2a9f93ab4e0416b2f4fdb63b3f8d Reviewed-on: https://chromium-review.googlesource.com/815874 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#522655} [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/autoclick/autoclick_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/display/display_configuration_controller_unittest.cc [delete] https://crrev.com/ef9ad27b1a663fa6e434fb32a03ca3275ea79134/ash/mus/window_manager_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/root_window_controller_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/rotator/screen_rotation_animator_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/screen_util_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/shell_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/web_notification/web_notification_tray_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/tooltips/tooltip_controller_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/window_manager_common_unittests.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/window_manager_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/testing/buildbot/filters/ash_unittests_mash.filter
,
Aug 14
Bug scrub: Still needs investigation.
,
Aug 14
,
Sep 14
,
Sep 25
Ryan, could you look at this to see if this needs anything for single-process-mash. If it doesn't, please update labels appropriately.
,
Sep 26
,
Sep 26
Seeing an occasional crash when repeatedly expanding/collapsing the launcher. Otherwise, functionality wise it looks to be working ok. [20744:20744:0926/152932.982766:ERROR:desktop_window_tree_host_mus.cc(219)] Not implemented reached in virtual void views::(anonymous namespace)::NativeCursorManagerMus::SetMouseEventsEnabled(bool, wm::NativeCursorManagerDelegate *) [20744:20744:0926/152932.982982:FATAL:optional.h(620)] Check failed: storage_.is_populated_. #0 0x5b4c77a86dfc base::debug::StackTrace::StackTrace() #1 0x5b4c77a06870 logging::LogMessage::~LogMessage() #2 0x5b4c763079c7 content::RenderWidgetHostInputEventRouter::DispatchTouchEvent() #3 0x5b4c76309f0f content::RenderWidgetHostInputEventRouter::DispatchEventToTarget() #4 0x5b4c76318d24 content::RenderWidgetTargeter::FoundTarget() #5 0x5b4c763186e3 content::RenderWidgetTargeter::FindTargetAndDispatch() #6 0x5b4c76483e22 content::RenderWidgetHostViewEventHandler::OnTouchEvent() #7 0x5b4c782dad50 ui::EventHandler::OnEvent() #8 0x5b4c782da54e ui::EventDispatcher::ProcessEvent() #9 0x5b4c782da38c ui::EventDispatcherDelegate::DispatchEvent() #10 0x5b4c7b305fae ui::EventProcessor::OnEventFromSource() #11 0x5b4c7b30645c ui::EventSource::SendEventToSinkFromRewriter() #12 0x5b4c78e3fe96 aura::WindowTreeClient::OnWindowInputEvent() #13 0x5b4c75d2a6f0 ws::mojom::WindowTreeClientStubDispatch::Accept() #14 0x5b4c77af3347 mojo::InterfaceEndpointClient::HandleValidatedMessage() #15 0x5b4c77af7994 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #16 0x5b4c77af7177 mojo::internal::MultiplexRouter::Accept() #17 0x5b4c77af1fa8 mojo::Connector::ReadSingleMessage() #18 0x5b4c77af2811 mojo::Connector::ReadAllAvailableMessages() #19 0x5b4c77b06135 mojo::SimpleWatcher::OnHandleReady() #20 0x5b4c77a9d9d9 base::debug::TaskAnnotator::RunTask() #21 0x5b4c77a0ca1e base::MessageLoop::RunTask() #22 0x5b4c77a0cde2 base::MessageLoop::DoWork() #23 0x5b4c77a9a409 base::MessagePumpLibevent::Run() #24 0x5b4c77a2c635 base::RunLoop::Run() #25 0x5b4c776e21ca ChromeBrowserMainParts::MainMessageLoopRun() #26 0x5b4c76004d24 content::BrowserMainLoop::RunMainMessageLoopParts() #27 0x5b4c760077d2 content::BrowserMainRunnerImpl::Run() #28 0x5b4c760012f8 content::BrowserMain() #29 0x5b4c776d2228 content::ContentMainRunnerImpl::Run() #30 0x5b4c776d8cf2 service_manager::Main() #31 0x5b4c776d0561 content::ContentMain() #32 0x5b4c754016df ChromeMain #33 0x787a6df07736 __libc_start_main #34 0x5b4c75401509 _start
,
Oct 17
RenderWidgetHostInputEventRouter::DispatchTouchEvent() now checks if touch_location has a value. Looks like it was added here: https://chromium-review.googlesource.com/c/chromium/src/+/1240129 . I'm going to close this as fixed. Ryan, if you disagree please reopen. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by newcomer@chromium.org
, May 26 2017