The intention of this change is to ensure the consistency between notifications from Android apps and Chrome notifications. Android app can use their own custom notification view for a notification, so there is a risk to hide notification content by the close button and the settings button (for example, the notification from Play Music app uses upper right corner to show a cover image). This change was made to avoid that situation.

Notifications can be removed by swiping when using touch.

Sebastien and Hiro, please correct me if I'm wrong.

#1 is correct. Close and settings buttons are there to enable mouse usage but shouldn't hinder usage or visuals for touch.

> The intention of this change is to ensure the consistency between notifications from Android apps and Chrome notifications.

I'm running on a windows desktop! Why would consistency with a completely different platform matter?

How can you close the button with touch if you never see it (yes, you can use touch on windows desktop too).

I'm rather surprised we're going with hidden UI, isn't that typically a bad idea?

I'm reopening one more time. Feel free to close again if you still disagree.

Sebastien, what do you think about making the buttons always visible on non Chrome OS platforms?

I thought other platform would be moving to their respective system notification system  so I was only talking for ChromeOS. Feel free to make them always visible on Windows only, at this point this is more a browser team decision than a Cros team decision.

I'm removing chromeos from the list of effected Os's then. yhanada, please reenable for non-chromeos platforms. Also, I don't think you always show the close button correctly on mouse movement. In particular if you move the mouse directly over the close button it's possible to get in a situation where the close button doesn't show.

I've sent the fix[1] to review. Thank you for your advice!

[1]: https://chromium-review.googlesource.com/c/530726/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5af9b8213c9a95a05d452b56b39f96cf33ceca42

commit 5af9b8213c9a95a05d452b56b39f96cf33ceca42
Author: yhanada <yhanada@chromium.org>
Date: Tue Jun 13 03:26:14 2017

Make the control buttons on a notification always show on non Chrome OS platform.

BUG= 726812 
TEST=Checks that the close button is always shown on Linux and
     it is shown only when the mouse hovers on Chrome OS.

Change-Id: I42aaefe989780f9740bd4a7061ddd41cb0b8f64c
Reviewed-on: https://chromium-review.googlesource.com/530726
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478886}
[modify] https://crrev.com/5af9b8213c9a95a05d452b56b39f96cf33ceca42/ui/arc/notification/arc_notification_content_view.cc
[modify] https://crrev.com/5af9b8213c9a95a05d452b56b39f96cf33ceca42/ui/message_center/views/notification_view.cc

This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

We're pretty late into M60 and cracking down on merges for this milestone, I'd prefer to wait until M61.  If this is a critical bug that can't wait until M61, feel free to add back the Merge-Request-60 label and justification/reasoning why this should be considered for 60 and we'll re-review.

Thank you for reviewing.

 Issue 709314  has been merged into this issue.

+bustamante@ explicitly

#c10 is a trivial CL that restores the intended UX for our non-Chrome OS desktop users. Given that we show billions of these a day and I've heard confusion from other sources too, I think that we should consider it despite being late in the release cycle. Re-adding the label -- what do you think?

This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

bustamante@: ping?

I'm curious, wouldn't the confusion also apply to ChromeOS?

Sorry for the late response, we're splitting merge reviews among multiple milestone owners as we're no longer auto-approving CL's.  Please follow up with Abdul on this (abdulsyed@) as he already started the review.

Approving merge to M60. Since this is an issue faced by users, safe merge, approving it for M60. 

Thanks! I uploaded https://codereview.chromium.org/2954373002/ for the merge, but would like to ask the yhanada@ and/or yoshiki@ to verify (and submit if OK) since it's a manual merge.

(To be clear, because a file got renamed, not due to other scary reasons.)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afbceb46878cee15b862ed364670c01336deb73a

commit afbceb46878cee15b862ed364670c01336deb73a
Author: peter <peter@chromium.org>
Date: Tue Jun 27 02:25:31 2017

Make the control buttons on a notification always show on non Chrome OS platform.

BUG= 726812 
TEST=Checks that the close button is always shown on Linux and
     it is shown only when the mouse hovers on Chrome OS.
NOTRY=true
NOPRESUBMIT=true

Change-Id: I42aaefe989780f9740bd4a7061ddd41cb0b8f64c
Reviewed-on: https://chromium-review.googlesource.com/530726
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#478886}
Review-Url: https://codereview.chromium.org/2954373002
Cr-Commit-Position: refs/branch-heads/3112@{#475}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/afbceb46878cee15b862ed364670c01336deb73a/ui/arc/notification/arc_custom_notification_view.cc
[modify] https://crrev.com/afbceb46878cee15b862ed364670c01336deb73a/ui/message_center/views/notification_view.cc

peter@: Thank you for merging this CL.

Re #19: Consistent UI is better than separated UI for two kinds on notifications even if one of the usual UIs is changed, I think.

Tested the issue on Windows-10 & 7 and Ubuntu 14.04 using chrome latest Beta M60-60.0.3112.50 by following below steps.

Steps Followed:
1.Install chrome and add " Notifications Galore" app from web store.
2.Checked notifications as per screen cast.Observed that close icon in notifications displaying as expected.

@yhanada: Could you please let me know if i have missed anything and if possible,Please provide the specific URl / steps  of the issue which would help us to verify the issue further.

Thanks in Advance!

Deleted: 726812.ogv 7.2 MB

	726812.ogv 7.2 MB View Download

It looks working correctly. This CL make the close button visible without hovering on the notification.

@yhanada: Thanks for immediate feedback.As per comment #27 & 28. Observed that close icon in notifications displaying as expected. Hence adding TE-Verified label.

Thank You!