New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726811 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

webrtc 30s_datachannel_transfer user story failing on all desktop platforms

Project Member Reported by charliea@chromium.org, May 26 2017

Issue description

This benchmark seems like it's been failing since it's been introduced. Going to go ahead and disable the user story.
 
I'm trying to disable recording webrtc traces instead in https://codereview.chromium.org/2909653003/
#1: once that land & you confirm that it fixed the failing story. You can revert Charlie's disabled CL.
But landing my CL amounts to reverting Charlie's CL, right?
Or what do you mean?
1) Charlie land his CL that disable 30s_datachannel_transfer
2) You land your CL that enable multiple_peerconnections & disable Webrtc Trace
3) You verify that (2) makes multiple_peerconnections no longer fail
4) You revert (1)
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e87e6f6da577dfdacf64dab57c4e0b8533d63a16

commit e87e6f6da577dfdacf64dab57c4e0b8533d63a16
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri May 26 20:09:00 2017

Disable webrtc 30s_datachannel_transfer on desktop

TBR=nednguyen@google.com
NOTRY=true

Bug:  726811 
Change-Id: Iaaeeb9384f6f0b24cb4da518d45088fca2b97832
Reviewed-on: https://chromium-review.googlesource.com/517292
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#475100}
[modify] https://crrev.com/e87e6f6da577dfdacf64dab57c4e0b8533d63a16/tools/perf/page_sets/webrtc_cases.py

Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e5657e03379575203b9617d955e1c410d3db7f2

commit 0e5657e03379575203b9617d955e1c410d3db7f2
Author: ehmaldonado <ehmaldonado@chromium.org>
Date: Wed May 31 04:23:52 2017

WebRTC: Re-enable 30s datachannel telemetry test.

BUG= chromium:726811 

Review-Url: https://codereview.chromium.org/2908383002
Cr-Commit-Position: refs/heads/master@{#475797}

[modify] https://crrev.com/0e5657e03379575203b9617d955e1c410d3db7f2/tools/perf/page_sets/webrtc_cases.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41f35f571ad8143211ace51131687c7475392d96

commit 41f35f571ad8143211ace51131687c7475392d96
Author: mikecase <mikecase@chromium.org>
Date: Wed Jun 07 00:23:18 2017

Revert of WebRTC: Re-enable 30s datachannel telemetry test. (patchset #1 id:1 of https://codereview.chromium.org/2908383002/ )

Reason for revert:
Test timing out on many of the Desktop perf bots such as...

Linux Perf
Mac 10.11 Perf.Mac Pro 10.11Perf
Win 7 Interl GPU Perf

and about 10 more.

Original issue's description:
> WebRTC: Re-enable 30s datachannel telemetry test.
>
> BUG= chromium:726811 
>
> Review-Url: https://codereview.chromium.org/2908383002
> Cr-Commit-Position: refs/heads/master@{#475797}
> Committed: https://chromium.googlesource.com/chromium/src/+/0e5657e03379575203b9617d955e1c410d3db7f2

TBR=charliea@chromium.org,nednguyen@google.com,ehmaldonado@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= chromium:726811 

Review-Url: https://codereview.chromium.org/2927673002
Cr-Commit-Position: refs/heads/master@{#477483}

[modify] https://crrev.com/41f35f571ad8143211ace51131687c7475392d96/tools/perf/page_sets/webrtc_cases.py

Owner: ehmaldonado@chromium.org
Assigning this to ehmaldonado@, who's an owner of the webrtc benchmark. Can you please investigate why this benchmark is still failing?
Labels: -Pri-1 Pri-2
Also downgrading to P2 because the benchmark is disabled.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2acd66ad843d8602e4f761f5be87f921df640482

commit 2acd66ad843d8602e4f761f5be87f921df640482
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed Jun 21 21:37:44 2017

WebRTC: Move WebMediaPlayerMS::* events to their own category.

There is an issue with some telemetry tests where the "webrtc"
category produces too many traces (about 60GB) that cannot be 
processed within the time limit, causing the test to time out.

Since we only care about WebMediaPlayerMS::UpdateCurrentFrame,
we move WebMediaPlayerMS::* events to their own category
(webmediaplayerms).

Bug:  chromium:726811 
Change-Id: I32db8a1bbf8fb2537d7501b3092a008da07050b9
Reviewed-on: https://chromium-review.googlesource.com/539398
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Tommi Gunn <tommi@chromium.org>
Reviewed-by: Qiang Chen <qiangchen@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481311}
[modify] https://crrev.com/2acd66ad843d8602e4f761f5be87f921df640482/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/2acd66ad843d8602e4f761f5be87f921df640482/content/renderer/media/webmediaplayer_ms_compositor.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/783ee45f655483a1fa556c8a2d041c69f938e08d

commit 783ee45f655483a1fa556c8a2d041c69f938e08d
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue Jun 27 12:01:32 2017

Re-enable the WebRTC datachannel telemetry benchmark.

Bug:  chromium:726811 
Change-Id: I1d5cf620e6de5738921144e9ad5de9e50d48ec66
Reviewed-on: https://chromium-review.googlesource.com/549460
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482598}
[modify] https://crrev.com/783ee45f655483a1fa556c8a2d041c69f938e08d/tools/perf/page_sets/webrtc_cases.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c758edea81f75996869f2dc94eedc6e8ed8319a3

commit c758edea81f75996869f2dc94eedc6e8ed8319a3
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Wed Jun 28 10:31:01 2017

Revert "Re-enable the WebRTC datachannel telemetry benchmark."

This reverts commit 783ee45f655483a1fa556c8a2d041c69f938e08d.

Reason for revert: Still times out

Original change's description:
> Re-enable the WebRTC datachannel telemetry benchmark.
> 
> Bug:  chromium:726811 
> Change-Id: I1d5cf620e6de5738921144e9ad5de9e50d48ec66
> Reviewed-on: https://chromium-review.googlesource.com/549460
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#482598}

TBR=nednguyen@google.com,ehmaldonado@chromium.org

Change-Id: Id34227b05848a8d71a660248c2844130a3559437
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:726811 
Reviewed-on: https://chromium-review.googlesource.com/552017
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#482938}
[modify] https://crrev.com/c758edea81f75996869f2dc94eedc6e8ed8319a3/tools/perf/page_sets/webrtc_cases.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca336ec2b568b98d8260e00e958228d514f20bb

commit eca336ec2b568b98d8260e00e958228d514f20bb
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Fri Jun 30 20:34:56 2017

Re-enable WebRTC datachannel telemetry test.

It looks like transferring 100 MB over 10s generates little enough
traces, so it isn't a problem.

Bug:  chromium:726811 
Change-Id: I8e6fde33ec7c33fab4a90924c1ca6b773bdf88e0
Reviewed-on: https://chromium-review.googlesource.com/552549
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483806}
[modify] https://crrev.com/eca336ec2b568b98d8260e00e958228d514f20bb/tools/perf/page_sets/webrtc_cases.py

Status: Fixed (was: Assigned)
Test seems to be running ok now.

Sign in to add a comment