New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726796 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 726207



Sign in to add a comment

chromeos-server18 (sentinel server) is not deployed to by push-to-prod

Project Member Reported by akes...@chromium.org, May 26 2017

Issue description



chromeos-test@chromeos-server18:~/chromiumos/chromite$ git show
commit 4f423f7eceea51335d2cf3b19db49d4f636522f4 (HEAD, m/master, cros/master)
Author: Harsh Modi <harshmodi@google.com>
Date:   Sat Apr 1 18:11:34 2017 -0700
[snip]


according to `atest server` this server's role is:

Hostname     : chromeos-server18.cbf.corp.google.com
Status       : primary
Roles        : reserve
Attributes   : {}
Date Created : 2015-05-19 13:39:20
Date Modified: 2015-05-19 13:39:20
Note         : Sentinel


Probably that is a role that automated_deploy ignores for pushing. However, the implication of this is that the server must be manually updated to pull down the code for both the rpc_flight_monitor and swarm_mon services that we intend to run on it.


Prathmesh I guess you went through this when updating sentinel service. Do you have an opinion on how this server should be updated?
 
First approximation, I can just run repo sync on it manually...
If you're sync'ing stuff manually, please update both

/usr/local/autotest and ~/chromiumos (repo sync)

We should just add it to push-to-prod. This will update both repo automatically.
Owner: pprabhu@chromium.org
Status: Started (was: Untriaged)
Let's do this sooner than later: https://chromium-review.googlesource.com/c/287785/
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/23735d387fe2def5af55904a3883afb94412a6da

commit 23735d387fe2def5af55904a3883afb94412a6da
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri May 26 23:55:46 2017

Project Member

Comment 6 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/707569839f21b1686f15a7624b8880345bb7aba0

commit 707569839f21b1686f15a7624b8880345bb7aba0
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri May 26 23:57:14 2017

Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/707569839f21b1686f15a7624b8880345bb7aba0

commit 707569839f21b1686f15a7624b8880345bb7aba0
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri May 26 23:57:14 2017

Project Member

Comment 8 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3a3045652c43b07e48b226dd5d785117160ff1ad

commit 3a3045652c43b07e48b226dd5d785117160ff1ad
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Wed May 31 19:38:33 2017

[autoest] Add a server role 'sentinel'.

This role represents the sentinel server where a few administrative
daemons run.

BUG= chromium:726796 
TEST=atest server modify SERVER_HOSTNAME -r sentinel

Change-Id: I5c6ea6851196ec64b073ed5798f2c015e9cb48b7
Reviewed-on: https://chromium-review.googlesource.com/517269
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/3a3045652c43b07e48b226dd5d785117160ff1ad/site_utils/deploy_server.py
[modify] https://crrev.com/3a3045652c43b07e48b226dd5d785117160ff1ad/frontend/server/models.py

Cc: dgarr...@chromium.org pho...@chromium.org
+phobbs, dgarrett: when is the next push-to-prod planned?

chromeos-server18.cbf should get pushed in the next push-to-prod.

pprabhu@pprabhu:labtoolsbin$ atest server modify -s primary chromeos-server18.cbf.corp.google.com
Status of server chromeos-server18.cbf.corp.google.com is changed from backup to primary. Affected roles: sentinel
Server chromeos-server18.cbf.corp.google.com is modified successfully.
Hostname     : chromeos-server18.cbf.corp.google.com
Status       : primary
Roles        : sentinel
Attributes   : {}
Date Created : 2017-06-01 10:31:58
Date Modified: 2017-06-01 10:31:58
Note         : None

Mark verified after a successful push-to-prod.
Labels: -Restrict-View-Google
Nothing here is RVG.
Status: Fixed (was: Started)
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment