Issue metadata
Sign in to add a comment
|
30.3%-192.3% regression in media.tough_video_cases at 474497:474574 |
||||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 26 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8978509058843313696
,
May 26 2017
,
May 26 2017
=== Auto-CCing suspected CL author fsamuel@chromium.org === Hi fsamuel@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : fsamuel Commit : b520968f4ac40fb89ce25329134b388ca42cca12 Date : Thu May 25 03:10:42 2017 Subject: cc::SurfaceDependencyTracker should not crash when a Display goes away Bisect Details Configuration: mac_pro_perf_bisect Benchmark : media.tough_video_cases Metric : idle_wakeups_browser/video.html?src_tulip2.ogg_type_audio Change : 179.58% | 385.333333333 -> 1077.33333333 Revision Result N chromium@474496 385.333 +- 11.3725 6 good chromium@474535 378.833 +- 20.6599 6 good chromium@474538 381.167 +- 29.9138 6 good chromium@474539 1103.5 +- 67.1379 6 bad <-- chromium@474540 1056.0 +- 160.468 6 bad chromium@474545 1108.17 +- 109.183 6 bad chromium@474555 1086.0 +- 36.5513 6 bad chromium@474574 1077.33 +- 32.7923 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.tulip2.ogg.type.audio media.tough_video_cases Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8978509058843313696 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5783178821763072 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 26 2017
Issue 726798 has been merged into this issue.
,
May 27 2017
,
May 27 2017
Adding Eric Seckler because he landed CLs around the same time that affect the display scheduler. It seems unlikely that my CL would cause performance or memory regressions given surface synchronization is not turned on in Chrome yet. With that said, maybe I missed something and I'm trying to repro locally.
,
May 27 2017
Issue 726892 has been merged into this issue.
,
May 27 2017
Ohh I just realized what's causing this regression. SurfaceDependencyTracker is always observing the PrimaryBeginFrameSource which always observes the display's BeginFrameSource. This is causing these regressions. I have a CL in flight to fix this. https://codereview.chromium.org/2887453002/
,
May 27 2017
Issue 726936 has been merged into this issue.
,
May 27 2017
Issue 726893 has been merged into this issue.
,
May 27 2017
,
Jun 13 2017
,
Feb 26 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tguilbert@google.com
, May 26 2017