New issue
Advanced search Search tips

Issue 726772 link

Starred by 2 users
Status: Fixed
Owner:
dpranke@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

webkitpy unit test TestServerProcess fails if test-webkitpy output is redirected

Project Member Reported by qyears...@chromium.org, May 26 2017 
Just noticed an interesting failure when running the webkitpy unit tests:

 $ ./test-webkitpy webkitpy.layout_tests.port.server_process_unittest
7 tests passed, 0 skipped, 0 failures.                     

./test-webkitpy webkitpy.layout_tests.port.server_process_unittest > /tmp/out; cat /tmp/out
[1/7] webkitpy.layout_tests.port.server_process_unittest.TestQuoteData.test_binary_data passed
[2/7] webkitpy.layout_tests.port.server_process_unittest.TestQuoteData.test_newlines passed
[3/7] webkitpy.layout_tests.port.server_process_unittest.TestQuoteData.test_plain passed
[4/7] webkitpy.layout_tests.port.server_process_unittest.TestQuoteData.test_trailing_spaces passed
[5/7] webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_broken_pipe failed unexpectedly:
  Traceback (most recent call last):
    File ".../webkitpy/layout_tests/port/server_process_unittest.py", line 139, in test_broken_pipe
      server_process.write("should break")
    File ".../webkitpy/layout_tests/port/server_process.py", line 180, in write
      self.stop(0.0)
    File ".../webkitpy/layout_tests/port/server_process.py", line 393, in stop
      self._wait_for_data_and_update_buffers_using_select(now, stopping=True)
    File ".../webkitpy/layout_tests/port/server_process.py", line 284, in _wait_for_data_and_update_buffers_using_select
      data = self._proc.stdout.read()
  AttributeError: 'MockFile' object has no attribute 'read'
[6/7] webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_cleanup failed unexpectedly:
  Traceback (most recent call last):
    File ".../webkitpy/layout_tests/port/server_process_unittest.py", line 129, in test_cleanup
      server_process.stop()
    File ".../webkitpy/layout_tests/port/server_process.py", line 393, in stop
      self._wait_for_data_and_update_buffers_using_select(now, stopping=True)
    File ".../webkitpy/layout_tests/port/server_process.py", line 284, in _wait_for_data_and_update_buffers_using_select
      data = self._proc.stdout.read()
  AttributeError: 'MockFile' object has no attribute 'read'
[7/7] webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic passed
5 tests passed, 0 skipped, 2 failures.

This is interesting, but maybe not very important since test-webkitpy is generally not run with output redirected.

Comment 1 by qyears...@chromium.org, May 30 2017

Labels: Hotlist-GoodFirstBug

Comment 2 by dpranke@chromium.org, Jun 21 2017

Owner: dpranke@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84dc05fd513e3c4e7aa64f5dba954f8d0a641939

commit 84dc05fd513e3c4e7aa64f5dba954f8d0a641939
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Jun 21 17:06:19 2017

Fix failing webkitpy unittest.

One of the webkitpy unittests failed if you redirected the output
of test-webkitpy to a file. This CL fixes that, by implementing
a mock method that I had missed earlier.

R=qyearsley@chromium.org
BUG= 726772 

Change-Id: I49a8ed7c3453a1ff0ae03d43b64d1ea5af539c02
Reviewed-on: https://chromium-review.googlesource.com/541974
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481226}
[modify] https://crrev.com/84dc05fd513e3c4e7aa64f5dba954f8d0a641939/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84dc05fd513e3c4e7aa64f5dba954f8d0a641939

commit 84dc05fd513e3c4e7aa64f5dba954f8d0a641939
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Jun 21 17:06:19 2017

Fix failing webkitpy unittest.

One of the webkitpy unittests failed if you redirected the output
of test-webkitpy to a file. This CL fixes that, by implementing
a mock method that I had missed earlier.

R=qyearsley@chromium.org
BUG= 726772 

Change-Id: I49a8ed7c3453a1ff0ae03d43b64d1ea5af539c02
Reviewed-on: https://chromium-review.googlesource.com/541974
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481226}
[modify] https://crrev.com/84dc05fd513e3c4e7aa64f5dba954f8d0a641939/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py

Comment 5 by dpranke@chromium.org, Jun 21 2017

Status: Fixed (was: Started)
►

Sign in to add a comment