New issue
Advanced search Search tips

Issue 726771 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Re-use C++ metric enums in java

Project Member Reported by se...@chromium.org, May 26 2017

Issue description

We won't have to ensure they stay mirrored.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77b98c4aea6f046286c70ea05a083002ac7db519

commit 77b98c4aea6f046286c70ea05a083002ac7db519
Author: sebsg <sebsg@chromium.org>
Date: Wed May 31 21:34:33 2017

[Payments] Use C++ metric enums in Java.

BUG= 726771 

Review-Url: https://codereview.chromium.org/2904083003
Cr-Commit-Position: refs/heads/master@{#476034}

[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/BUILD.gn
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/BUILD.gn
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsUnitTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameAndFreeShippingTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/components/payments/core/journey_logger.cc
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/components/payments/core/journey_logger.h
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/components/payments/core/journey_logger_unittest.cc
[modify] https://crrev.com/77b98c4aea6f046286c70ea05a083002ac7db519/tools/android/eclipse/.classpath

Comment 2 by se...@chromium.org, Jun 1 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by se...@chromium.org, Jun 1 2017

Status: Fixed (was: Started)

Comment 5 by se...@chromium.org, Jun 2 2017

Labels: -Merge-Approved-60 Merge-Merged
Hum the bot was not triggered? I merged it to 60 here: https://codereview.chromium.org/2915073003/
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment