[TTS] Resolved term does not always expand the selection |
||
Issue descriptionI'm noticing cases where the resolved search doesn't always expand the selection. E.g. when I search for "food" and tap on "Healthy Eating" a tap on "Healthy" will only sometimes expand to include "Eating" even though it appears that the resolve returns the same search each time. Might be a regression due to recent refactoring.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08060b17bf13ffc5bd17f6d863727a2cfa834119 commit 08060b17bf13ffc5bd17f6d863727a2cfa834119 Author: donnd <donnd@chromium.org> Date: Fri Jun 02 01:02:34 2017 [TTS] Fix expanding selection at end of some lines Fixes a bug where the resolved term isn't always selected in the text. The case fixed is due to the selection including a trailing space when at the end of a line. It's unclear why the trailing space is included in the selection. We simply trim the trailing space. BUG= 726767 Review-Url: https://codereview.chromium.org/2910713002 Cr-Commit-Position: refs/heads/master@{#476506} [modify] https://crrev.com/08060b17bf13ffc5bd17f6d863727a2cfa834119/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
,
Jun 2 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by donnd@chromium.org
, May 26 2017