New issue
Advanced search Search tips

Issue 726762 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Task

Blocking:
issue 719108



Sign in to add a comment

"change" event should be fired at the NetworkInformation object when network quality changes

Project Member Reported by tbansal@chromium.org, May 26 2017

Issue description

Currently, "change" event is fired at the NetworkInformation object when there is a change in the connection type or max. bandwidth.

The "change" event should also be fired when there is a change in the network quality. This is part of the updated NetInfo spec: 
https://cdn.rawgit.com/WICG/netinfo/ect/index.html#handling-changes-to-the-underlying-connection

 
Labels: -Type-Bug Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f51122ff533e752a86a27193ca7539c450b3670e

commit f51122ff533e752a86a27193ca7539c450b3670e
Author: tbansal <tbansal@chromium.org>
Date: Fri Jun 02 07:00:38 2017

NetInfo network quality extension: Add callbacks and Layout tests

"change" event is fired from NetworkInformation.cpp when there
is a change in the network quality.

Also, layout tests have been added for the network quality extension
to the NetInfo API.

BUG= 725282 ,  726762 

Review-Url: https://codereview.chromium.org/2903493002
Cr-Commit-Position: refs/heads/master@{#476595}

[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/basic-operation-expected.txt
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/basic-operation.html
[add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation-expected.txt
[add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation.html
[add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames-expected.txt
[add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames.html
[add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker-expected.txt
[add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker.html
[add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/network-quality-expected.txt
[add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/network-quality.html
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/resources/web-worker.js
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener-expected.txt
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/unregister-during-event-expected.txt
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/web-worker.html
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/html/HTMLMediaElementTest.cpp
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/platform/network/NetworkStateNotifier.h
[modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp

Labels: Merge-Request-60
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 3 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 6 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the fix. 

Please confirm whether the fix is verified in canary. If yes, merge to 3112 branch ASAP.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52551041771eca1ec73306e43c9ad370b7131887

commit 52551041771eca1ec73306e43c9ad370b7131887
Author: Tarun Bansal <tbansal@google.com>
Date: Tue Jun 06 20:20:21 2017

NetInfo network quality extension: Add callbacks and Layout tests

"change" event is fired from NetworkInformation.cpp when there
is a change in the network quality.

Also, layout tests have been added for the network quality extension
to the NetInfo API.

BUG= 725282 ,  726762 

Review-Url: https://codereview.chromium.org/2903493002
Cr-Original-Commit-Position: refs/heads/master@{#476595}
Review-Url: https://codereview.chromium.org/2924913002 .
Cr-Commit-Position: refs/branch-heads/3112@{#204}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/basic-operation-expected.txt
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/basic-operation.html
[add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation-expected.txt
[add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation.html
[add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames-expected.txt
[add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames.html
[add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker-expected.txt
[add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker.html
[add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/network-quality-expected.txt
[add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/network-quality.html
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/resources/web-worker.js
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener-expected.txt
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/unregister-during-event-expected.txt
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/web-worker.html
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/html/HTMLMediaElementTest.cpp
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/platform/network/NetworkStateNotifier.h
[modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment