New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726758 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

foomatic-rip did not catch or ignore signal 13

Project Member Reported by skau@chromium.org, May 26 2017

Issue description

Chrome Version: 60
OS: ChromeOS

What steps will reproduce the problem?
(1) Load PPD for Ricoh-MP_C3503 http://www.openprinting.org/ppd-o-matic.php?driver=pxlcolor-Ricoh&printer=Ricoh-MP_C3503&show=0
(2) Setup Printer
(3) Press Print

What is the expected result?
Print job fails in error because the PPD depends on perl and we don't install Perl

What happens instead?
Erroneous report of a successful print job.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by skau@chromium.org, Aug 30 2017

Cc: skau@chromium.org
Owner: luum@chromium.org

Comment 2 by skau@chromium.org, Aug 30 2017

Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/f6b430772a44507b37614dda9936fba19890ceec

commit f6b430772a44507b37614dda9936fba19890ceec
Author: Luum Habtemariam <luum@google.com>
Date: Wed Sep 27 19:58:02 2017

foomatic-rip failure status fix

Changes execution of renderer thread in the foomatic-rip package to fail
whenever any of its individual sub-commands fails

Global SIGPIPE signal handler now only pertains to parent process. Children will
still fail and parent process will now notice and gracefully exit
accordingly.

BUG= chromium:726758 
TEST=Printed job and foomatic now reports correct error code
Change-Id: I9e60ec3edde800a8451cdc1e48c4204ae94ca526
Reviewed-on: https://chromium-review.googlesource.com/673026
Commit-Ready: Luum Habtemariam <luum@chromium.org>
Tested-by: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[rename] https://crrev.com/f6b430772a44507b37614dda9936fba19890ceec/net-print/cups-filters/cups-filters-1.8.2-r4.ebuild
[add] https://crrev.com/f6b430772a44507b37614dda9936fba19890ceec/net-print/cups-filters/files/cups-filters-1.8.2-foomatic-rip-sig-pipe.patch

Comment 4 by luum@chromium.org, Sep 27 2017

Status: Fixed (was: Assigned)
per patch above
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 7 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/8d736c049685ddfe70f34e38a8ce406605750153

commit 8d736c049685ddfe70f34e38a8ce406605750153
Author: Luum Habtemariam <luum@chromium.org>
Date: Sat Oct 07 04:31:13 2017

net-print/cups-filters: Added patch description

Added description to cups-filters-1.8.2-foomatic-rip-sig-pipe.patch

BUG= chromium:726758 
TEST=manually confirmed patch behavior unchanged
Change-Id: I41753ba72245e3f34b2c5dd60afb2a7af56325ad
Reviewed-on: https://chromium-review.googlesource.com/689741
Commit-Ready: Luum Habtemariam <luum@chromium.org>
Tested-by: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/8d736c049685ddfe70f34e38a8ce406605750153/net-print/cups-filters/files/cups-filters-1.8.2-foomatic-rip-sig-pipe.patch
[rename] https://crrev.com/8d736c049685ddfe70f34e38a8ce406605750153/net-print/cups-filters/cups-filters-1.8.2-r5.ebuild

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment