Many canaries failing in chromeos-base/authpolicy unit test. |
||||||||||
Issue descriptionThe two authpolicy related CLs that landed between the last success and first failure are: https://chromium-review.googlesource.com/c/514086/ https://chromium-review.googlesource.com/c/484320/ Assigning to the author of those CLs to investigate. Here's one build that failed: http://shortn/_Hlrau6aEcN Here's a snippet of some tests that failed. ----------8<------------ authpolicy-0.0.1-r388: [0;31m[ FAILED ] [m2 tests, listed below: authpolicy-0.0.1-r388: [0;31m[ FAILED ] [mAuthPolicyFlagsTest.TestAllFlagsOn authpolicy-0.0.1-r388: [0;31m[ FAILED ] [mAuthPolicyFlagsTest.FlagsSerialization ... uthpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:55: Failure authpolicy-0.0.1-r388: Value of: flags.disable_seccomp() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:56: Failure authpolicy-0.0.1-r388: Value of: flags.log_seccomp() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:57: Failure authpolicy-0.0.1-r388: Value of: flags.trace_kinit() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:58: Failure authpolicy-0.0.1-r388: Value of: flags.log_policy_values() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:59: Failure authpolicy-0.0.1-r388: Value of: flags.log_commands() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:60: Failure authpolicy-0.0.1-r388: Value of: flags.log_command_output() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:61: Failure authpolicy-0.0.1-r388: Value of: flags.log_command_output_on_error() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:62: Failure authpolicy-0.0.1-r388: Value of: flags.log_gpo() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:63: Failure authpolicy-0.0.1-r388: Value of: flags.log_config() authpolicy-0.0.1-r388: Actual: false authpolicy-0.0.1-r388: Expected: true authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:64: Failure authpolicy-0.0.1-r388: Value of: flags.net_log_level() authpolicy-0.0.1-r388: Actual: "" authpolicy-0.0.1-r388: Expected: "10" authpolicy-0.0.1-r388: [0;31m[ FAILED ] [mAuthPolicyFlagsTest.TestAllFlagsOn (1 ms) authpolicy-0.0.1-r388: [0;32m[ RUN ] [mAuthPolicyFlagsTest.FlagsSerialization authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:72: Failure authpolicy-0.0.1-r388: Value of: flags_encoded.empty() authpolicy-0.0.1-r388: Actual: true authpolicy-0.0.1-r388: Expected: false authpolicy-0.0.1-r388: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags_unittest.cc:80: Failure authpolicy-0.0.1-r388: Value of: flags_str2 authpolicy-0.0.1-r388: Actual: "" authpolicy-0.0.1-r388: Expected: flags_str authpolicy-0.0.1-r388: Which is: "H\x1R\x1" "5" authpolicy-0.0.1-r388: [0;31m[ FAILED ] [mAuthPolicyFlagsTest.FlagsSerialization (0 ms) ----------8<------------
,
May 26 2017
Daniel, I've seen that you've reviewed other authpolicy changes in the past. Is this something you can help with or should we just revert the two changes?
,
May 26 2017
,
May 26 2017
cd ~/trunk/src/platform2/authpolicy git log --pretty=format:"%h %cr %ae %s" . 25d6117fe 37 minutes ago tnagel@chromium.org Remove references to individual genders 2da56b545 19 hours ago ljusten@chromium.org authpolicy: Report password expiration and last auth error 1589f9dff 19 hours ago ljusten@chromium.org authpolicy: Reland "Add debug flags for logging, turn off by default" 5e88750f3 2 days ago hychao@chromium.org Revert "authpolicy: Add debug flags for logging, turn off by default" d6e9f81b6 3 days ago ljusten@chromium.org authpolicy: Add debug flags for logging, turn off by default Hrm...since this was reverted once before, I'm wondering why the 2cd attempt is still failing. But the commit message indicates this change wasn't tested: TEST=None Will see if the failure is obvious, and if not, I'll revert again. (Apologies in advance if I or aaboagye revert)
,
May 26 2017
Update (via email) from Lutz Justen: "Apologies that I reply by mail, I'm OOO today and I can't access my workstation. Fwiw, it would be OK to just disable the tests for now until I can fix them on Monday. The broken feature is not used in production and authpoliyd isn't launched yet, so it won't impact anybody. Thanks, - Lutz" Ok...let me figure out if I can disable the unit tests.
,
May 26 2017
Lutz suggested: | Commenting out the tests in authpolicy_flags_unittest.cc.should do it. Sorry for the inconvenience! preparing a CL for that now.
,
May 27 2017
Lutz, This change should land this evening: https://chromium-review.googlesource.com/517424 authpolicy: disable AuthPolicyFlagsTest just revert it once you have the unit tests working AND trybots (cbuildbot commmand in the TEST=) are passing.
,
May 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5815153e08968525ff97d40873433dce7b930988 commit 5815153e08968525ff97d40873433dce7b930988 Author: Grant Grundler <grundler@google.com> Date: Mon May 29 20:01:20 2017 authpolicy: disable AuthPolicyFlagsTest Lutz Jenzen wrote: | Fwiw, it would be OK to just disable the tests for now until I can fix | them on Monday. The broken feature is not used in production and | authpoliyd isn't launched yet, so it won't impact anybody. BUG= chromium:726757 TEST=cbuildbot --remote -g <CL number> asuka-release Change-Id: I2f5e2abf4485ed5a1dd5dc1adabd5f15925a1409 Reviewed-on: https://chromium-review.googlesource.com/517424 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> Tested-by: Grant Grundler <grundler@chromium.org> [modify] https://crrev.com/5815153e08968525ff97d40873433dce7b930988/authpolicy/authpolicy_flags_unittest.cc
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f327b74f8db73bbfc68a6c9d93352a665af33845 commit f327b74f8db73bbfc68a6c9d93352a665af33845 Author: Lutz Justen <ljusten@chromium.org> Date: Wed May 31 09:15:27 2017 authpolicy: Fix failing authpolicy_flags tests in release DCHECK'ed code that should be enabled in release builds. BUG= chromium:726757 TEST=cbuildbot --remote -g 518105 asuka-release Change-Id: I0e81a7eafeaab84be5fbb8648df77f490921615b Reviewed-on: https://chromium-review.googlesource.com/518105 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/f327b74f8db73bbfc68a6c9d93352a665af33845/authpolicy/authpolicy_flags.cc [modify] https://crrev.com/f327b74f8db73bbfc68a6c9d93352a665af33845/authpolicy/authpolicy_flags_unittest.cc
,
May 31 2017
This is also affecting M60 builders ljusten@ cab you merge fixes to M60 branch?
,
May 31 2017
Sure, we'll do that.
,
May 31 2017
Issue 728189 has been merged into this issue.
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/cfb6b3cef0154d6be60a9ebc0c34e32ff9e515a1 commit cfb6b3cef0154d6be60a9ebc0c34e32ff9e515a1 Author: Lutz Justen <ljusten@chromium.org> Date: Wed May 31 16:18:16 2017 authpolicy: Fix failing authpolicy_flags tests in release DCHECK'ed code that should be enabled in release builds. BUG= chromium:726757 TEST=cbuildbot --remote -g 518105 asuka-release Change-Id: I0e81a7eafeaab84be5fbb8648df77f490921615b Reviewed-on: https://chromium-review.googlesource.com/518105 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> (cherry picked from commit f327b74f8db73bbfc68a6c9d93352a665af33845) Reviewed-on: https://chromium-review.googlesource.com/519148 Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Trybot-Ready: Lutz Justen <ljusten@chromium.org> [modify] https://crrev.com/cfb6b3cef0154d6be60a9ebc0c34e32ff9e515a1/authpolicy/authpolicy_flags.cc
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7d0ba78ff5ab74cd684241fbef18462b39ebaf13 commit 7d0ba78ff5ab74cd684241fbef18462b39ebaf13 Author: Grant Grundler <grundler@google.com> Date: Wed May 31 16:18:19 2017 authpolicy: disable AuthPolicyFlagsTest Lutz Jenzen wrote: | Fwiw, it would be OK to just disable the tests for now until I can fix | them on Monday. The broken feature is not used in production and | authpoliyd isn't launched yet, so it won't impact anybody. BUG= chromium:726757 TEST=cbuildbot --remote -g <CL number> asuka-release Change-Id: I2f5e2abf4485ed5a1dd5dc1adabd5f15925a1409 Reviewed-on: https://chromium-review.googlesource.com/517424 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> Tested-by: Grant Grundler <grundler@chromium.org> (cherry picked from commit 5815153e08968525ff97d40873433dce7b930988) Reviewed-on: https://chromium-review.googlesource.com/519147 Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Trybot-Ready: Lutz Justen <ljusten@chromium.org> [modify] https://crrev.com/7d0ba78ff5ab74cd684241fbef18462b39ebaf13/authpolicy/authpolicy_flags_unittest.cc
,
May 31 2017
,
Jun 5 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
This looks like it was already merged to M60.
,
Jan 22 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by aaboagye@chromium.org
, May 26 2017