New issue
Advanced search Search tips

Issue 726751 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

ARIA treeitem must support checkable, checked states via ARIA

Project Member Reported by aleventhal@chromium.org, May 26 2017

Issue description

If an element with role="treeitem" includes @aria-checked, it must be exposed as checkable, and expose the appropriate states for checked.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c

commit 98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Thu Jun 01 20:55:44 2017

Support aria-pressed="mixed" and refactor mixed state support to reuse internal checked tristate.

Includes failing tests from https://codereview.chromium.org/2707263011/ and https://codereview.chromium.org/2906083002/
Bug:  726740 , 726751 
Change-Id: I6b06018f805c4fce781843141109626bab557dcc

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6b06018f805c4fce781843141109626bab557dcc
Reviewed-on: https://chromium-review.googlesource.com/516586
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476430}
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/ash/system/audio/volume_view.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/ash/system/night_light/night_light_toggle_button.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/chrome/test/data/extensions/api_test/automation/sites/attributes.html
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/browser/accessibility/browser_accessibility_manager_mac.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/browser/accessibility/browser_accessibility_manager_mac.mm
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/shell/test_runner/web_ax_object_proxy.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/aria/aria-pressed-expected-android.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/aria/aria-pressed-expected-win.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/aria/aria-pressed.html
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/aria/aria-tree-expected-android.txt
[add] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/aria/aria-tree-expected-blink.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/aria/aria-tree-expected-mac.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/aria/aria-tree-expected-win.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/aria/aria-tree.html
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/event/checked-state-changed-expected-mac.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/event/checked-state-changed-expected-win.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/event/checked-state-changed.html
[add] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/event/pressed-state-change.html
[add] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/event/pressed-state-changed-expected-mac.txt
[add] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/content/test/data/accessibility/event/pressed-state-changed-expected-win.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-expected.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-mixed.html
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked.html
[add] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/accessibility/aria-treeitem-checkable.html
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/accessibility/input-mixed.html
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/accessibility/option-aria-checked.html
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/core/dom/AXObject.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/core/dom/AccessibleNode.idl
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/third_party/WebKit/public/web/WebAXObject.h
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/98e8c6fbeee3d932ed3ce37dbfd8630246dfcf9c/ui/views/controls/button/image_button.cc

Status: Fixed (was: Assigned)

Sign in to add a comment