Issue metadata
Sign in to add a comment
|
Large number of strings being displayed with placeholders |
||||||||||||||||||||
Issue descriptionmaps_pixel_test on ATI GPU on Mac Retina failing on chromium.gpu/Mac Retina Debug (AMD) Builders failed on: - Mac Retina Debug (AMD): https://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug%20%28AMD%29 Suspecting https://chromium.googlesource.com/chromium/src/+/6a6a15f202793feded8b2be696b914f16e8f39a8 [38470:775:0526/081323.138557:FATAL:l10n_util.cc(698)] Check failed: std::string::npos == pos (18446744073709551615 vs. 22) Unexpectedly found a $1 placeholder in Warn Before Quitting ($1) 0 libbase.dylib 0x0000000102ec78be base::debug::StackTrace::StackTrace(unsigned long) + 174 1 libbase.dylib 0x0000000102ec795d base::debug::StackTrace::StackTrace(unsigned long) + 29 2 libbase.dylib 0x0000000102ec5bdc base::debug::StackTrace::StackTrace() + 28 3 libbase.dylib 0x0000000102f65c0f logging::LogMessage::~LogMessage() + 479 4 libbase.dylib 0x0000000102f63585 logging::LogMessage::~LogMessage() + 21 5 libui_base.dylib 0x000000010843ce4c l10n_util::GetStringUTF16(int) + 1756 6 libui_base.dylib 0x0000000108453f5c l10n_util::GetNSStringWithFixup(int) + 44 7 libchrome_dll.dylib 0x000000010fc23cf6 -[ChromeUILocalizer localizedStringForString:] + 326 8 libgoogle_toolbox_for_mac.dylib 0x000000012f463357 -[GTMUILocalizer localizeMenu:recursively:] + 567 9 libgoogle_toolbox_for_mac.dylib 0x000000012f4617c6 -[GTMUILocalizer localizeObject:recursively:] + 358 10 libgoogle_toolbox_for_mac.dylib 0x000000012f4633ea -[GTMUILocalizer localizeMenu:recursively:] + 714 11 libgoogle_toolbox_for_mac.dylib 0x000000012f461901 -[GTMUILocalizer localizeObject:recursively:] + 673 12 libchrome_dll.dylib 0x000000010fc23b0d -[GTMUILocalizer(PrivateAdditions) localizedObjects] + 61 13 libchrome_dll.dylib 0x000000010fc23b9b -[ChromeUILocalizer awakeFromNib] + 43 14 CoreFoundation 0x00007fffb5df20a9 -[NSSet makeObjectsPerformSelector:] + 217 15 AppKit 0x00007fffb38b9c8b -[NSIBObjectData nibInstantiateWithOwner:options:topLevelObjects:] + 1442 16 AppKit 0x00007fffb39c279a -[NSNib _instantiateNibWithExternalNameTable:options:] + 696 17 AppKit 0x00007fffb39c23ce -[NSNib _instantiateWithOwner:options:topLevelObjects:] + 143 18 libchrome_dll.dylib 0x000000010a23ba8e ChromeBrowserMainPartsMac::PreMainMessageLoopStart() + 1406 19 libcontent.dylib 0x000000011ddb0ad0 content::BrowserMainLoop::PreMainMessageLoopStart() + 336 20 libcontent.dylib 0x000000011ddc41bb content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 1563 21 libcontent.dylib 0x000000011ddac4ad content::BrowserMain(content::MainFunctionParams const&) + 285 22 libcontent.dylib 0x0000000120233355 content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 581 23 libcontent.dylib 0x0000000120234e22 content::ContentMainRunnerImpl::Run() + 1938 24 libcontent.dylib 0x00000001202319dd content::ContentServiceManagerMainDelegate::RunEmbedderProcess() + 61 25 libembedder.dylib 0x00000001028c49c4 service_manager::Main(service_manager::MainParams const&) + 1892 26 libcontent.dylib 0x00000001202330c9 content::ContentMain(content::ContentMainParams const&) + 89 27 libchrome_dll.dylib 0x0000000108708cce ChromeMain + 270 28 Chromium 0x0000000100b5ad9d main + 813 29 libdyld.dylib 0x00007fffcb552235 start + 1 30 ??? 0x0000000000000016 0x0 + 22
,
May 26 2017
,
May 26 2017
Now reverting https://chromium-review.googlesource.com/c/517222
,
May 26 2017
another revert CL is already in the CQ https://chromium-review.googlesource.com/c/517066
,
May 26 2017
I added a DCHECK that when we read a string from the bundle without supplying replacements, then the string shouldn't contain placeholders. It turns out that this doesn't hold left and right. I had a quick look at some of the failed tests, and in all cases, these are actually bugs :/
,
May 28 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 20
*** UI Mass Triage*** |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by fdoray@chromium.org
, May 26 2017