New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726744 link

Starred by 1 user
Status: Verified
Owner:
█ ymalik@chromium.org
(currently inactive on Chromium)
Closed: Jun 2017
Cc:
█ vollick@chromium.org
█ joshcarpenter@chromium.org
cjgrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Handle clicking on the security warning icon

Project Member Reported by ymalik@chromium.org, May 26 2017 
For Chrome on Android, clicking on the security warning icon brings down an infobar from the top bezel with information like the the url, security state, etc. We would probably eventually want something like this in VR, but need something minimal for BBB.

Here's one possibility:
   - User clicks on the icon
   - We show something like "This is unsupported in VR, if you'd like to learn more about this site, view in 2D" with two options "Yes", "Cancel"
   - Clicking on "Cancel" gets rid of the prompt and does nothing
   - Clicking on "Yes" exits VR and shows the Android UI with more details.

Assigning to joshcarpenter@ for UX.

Comment 1 by joshcarpenter@chromium.org, May 26 2017 

Use should also be able to dismiss (cancel) by clicking anywhere outside the bounds of the UI prompt.

Comment 2 by ymalik@chromium.org, May 30 2017

Owner: ymalik@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0bfe51c05f2240fde6cbdf547be0b3ae3be8b5b

commit d0bfe51c05f2240fde6cbdf547be0b3ae3be8b5b
Author: Michael Thiessen <mthiesse@google.com>
Date: Tue Jun 06 17:24:54 2017

VR: Make DOFF flow optional for CCT exit

If the user hits back in the DOFF flow, for certain flows like CCT exit
we allow the user to stay in VR.

Bug:  726744 
Change-Id: Iefc7b606b5974c256575df5aeefa86e44d20151c
Reviewed-on: https://chromium-review.googlesource.com/526112
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477318}
[modify] https://crrev.com/d0bfe51c05f2240fde6cbdf547be0b3ae3be8b5b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Comment 4 by ddorwin@chromium.org, Jun 6 2017

Labels: Proj-VR-Shell
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db30f9ca562c571e7233710f0e9f69a882a7045e

commit db30f9ca562c571e7233710f0e9f69a882a7045e
Author: ymalik <ymalik@chromium.org>
Date: Wed Jun 07 04:25:24 2017

[vr] Clicking on the security icon should prompt the user to bail out of VR

BUG= 726744 

Review-Url: https://codereview.chromium.org/2913633002
Cr-Commit-Position: refs/heads/master@{#477546}

[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/app/generated_resources.grd
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/color_scheme.h
[add] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/textures/exit_prompt_texture.cc
[add] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/textures/exit_prompt_texture.h
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[add] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_elements/exit_prompt.cc
[add] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_elements/exit_prompt.h
[add] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_elements/exit_prompt_unittest.cc
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/ui_unsupported_mode.h
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/tools/metrics/actions/actions.xml
[modify] https://crrev.com/db30f9ca562c571e7233710f0e9f69a882a7045e/tools/metrics/histograms/enums.xml

Comment 6 by ymalik@chromium.org, Jun 7 2017

Labels: Merge-Request-60

Comment 7 by candr...@chromium.org, Jun 7 2017 

Please tag with applicable OSs.  Thanks.

Comment 8 by vollick@chromium.org, Jun 7 2017

Labels: OS-Android
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: There is .grd file changes and we are only 54 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by amineer@chromium.org, Jun 7 2017

Labels: -Merge-Review-60 Merge-Rejected-60
c#5 rejected as discussed offline.  Please re-request when you have a smaller CL available for merge.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9

commit ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9
Author: ymalik <ymalik@chromium.org>
Date: Thu Jun 08 19:39:07 2017

[vr] Close exit prompt when clicking on background

This is a follow-up patch to https://codereview.chromium.org/2913633002/

BUG= 726744 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2921383002
Cr-Commit-Position: refs/heads/master@{#478057}

[modify] https://crrev.com/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9/chrome/browser/android/vr_shell/ui_elements/exit_prompt_backplane.cc
[add] https://crrev.com/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9/chrome/browser/android/vr_shell/ui_elements/exit_prompt_backplane.h
[modify] https://crrev.com/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9/chrome/browser/android/vr_shell/ui_elements/loading_indicator.cc
[modify] https://crrev.com/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9/chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h
[modify] https://crrev.com/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/ee13d1180e1625c5d5f6b1ef4b4b90192be20cb9/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc

Comment 12 by ymalik@chromium.org, Jun 9 2017

Status: Fixed (was: Started)

Comment 13 by ddorwin@chromium.org, Jun 20 2017

Labels: -M-60 M-61
This was landed in M61.

Comment 14 by vsupruniuk@google.com, Jun 22 2017

Status: Verified (was: Fixed)
Verified in Chrome Canary 61.0.3138.0
►

Sign in to add a comment