--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

ping Alan

What assets are exported at 1x and 2x that you're referring to? How do we ensure quality across fractional displays then? 

Literally all the icons in primary ui have two definitions: navigation icons, close buttons, the bookmark star, the app menu icon, bookmark folders, etc.

Currently we don't ensure pixel perfection at fractional scale factors, or even 3x for that matter, but pixel perfection is less important/noticeable the greater the dsf.

Do you remember where the cutover is?  My memory is that we use 1x for all DSFs < 2, and 2x for all DSFs >= 2.

Things aren't too bad since these are vector-based.  It's just that for low pixel densities we wanted some more-optimized versions.

It's 1x for 1x and 2x (scaled) for all else.

So there's 1x and 2x svgs for all primary UI and then we programmatically color?

Yes. Some icons that are larger and/or less prominent only have one variety. Also note that 1x and 2x never differ only in scale (that would defeat the purpose of the specific 1x asset).

I looked into it...supplying 1 variety vs. 2 makes little difference from the UX side of things. Does it make a difference for eng? 

Arguably, the scaled version is better than the rest (#3). See attached

1 - major modifications to original scaled artwork
2 - 2px modification to original scaled artwork
3 - original scaled artwork

Deleted: Screen Shot 2017-07-17 at 12.00.27 PM.png 26.3 KB

	Screen Shot 2017-07-17 at 12.00.27 PM.png 26.3 KB View Download

>  Does it make a difference for eng? 

Nope. If we're happy with the way the scaled version looks, we're all good here. Usually pixel perfection consists of aligning straight lines to pixel boundaries but there are no straight lines in this icon, so it makes some sense if we just stick to plain scaling.

Sticking with plain scaling works for me then