New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726718 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 710025



Sign in to add a comment

Move resource_sizes patch size estimation and static initializer counting from builders to testers

Project Member Reported by estevenson@chromium.org, May 26 2017

Issue description

There's 500-600 pending builds: https://build.chromium.org/p/chromium.perf/builders/Android%20Builder.

This will be obsoleted by issue 710025 but if it's not too much trouble can we fix this in the meantime?

Not a huge deal or anything, but we use artifacts from this builder for binary size analysis and alerts. It would be nicer to be able to access these artifacts relatively soon after submitting a CL and to be able to catch regressions quickly.
 
Cc: rnep...@chromium.org martiniss@chromium.org
We're spending more time doing resource_sizes on the bot than we are on compilation :/
Ouch. Probably due to the static initializer counting being really slow..

Since the resource_sizes step shows 0s duration, I'm assuming the Sharded Perf Tests steps show the time resource_sizes is taking?
Correct. iirc the actual 'resource_sizes' step is just printing the results of running resource_sizes in Sharded Perf Tests.
Yep, to find the run time of an individual test using the perf test runner you look at 'sharded perf tests' and search for the test name or for exit_code.

I  221.621s run_no_devices_tests  resource_sizes (ChromePublic.apk) : exit_code=0 in 221 secs.

Owner: estevenson@chromium.org
Status: Assigned (was: Untriaged)
Summary: Move resource_sizes patch size estimation and static initializer counting from builders to testers (was: Android perf builder has many pending build requests)
We can move patch size estimation and static initializer counting from builders to testers since they don't need to be run on every commit. 

The rest of resource_sizes is fast and we want to maintain per commit binary size growth.
Cc: dtu@chromium.org nedngu...@google.com
cc'ing a few folks who might know the answer.

Any ideas on where I can add non-telemetry tests? It was suggested to me that https://cs.chromium.org/chromium/src/tools/perf/core/perf_data_generator.py might be the place to look but everything in there looks pretty specific to running tests on devices.

Ideally we'd like to run this on one 64 bit bot and one 32 bit bot.
Components: Speed>Benchmarks
#6, that is the right place to poke at. However, we don't have a support for "running this test" on a 64 bit bot & 32 bit bot. Right now you just specify the specific builder you want.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ab22ee27d6289165c8303b9f7d2dabe45ce3b25

commit 7ab22ee27d6289165c8303b9f7d2dabe45ce3b25
Author: Eric Stevenson <estevenson@chromium.org>
Date: Fri Jun 09 20:06:02 2017

resource_sizes.py: Don't list static initializers by default.

Running tools/linux/dump-static-initializers.py is very slow on Android
so skip running it by default.

This should help with the backlog of pending builds on Android perf
builders. We only report the number of files with static initializers
on bots and we don't store the list of static initializers anywhere so
it isn't very helpful to print them at all.

Bug:  726718 
Change-Id: I73628c101f138e9c8dc9347bceb813a979b55f6c
Reviewed-on: https://chromium-review.googlesource.com/529268
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478386}
[modify] https://crrev.com/7ab22ee27d6289165c8303b9f7d2dabe45ce3b25/build/android/resource_sizes.py
[modify] https://crrev.com/7ab22ee27d6289165c8303b9f7d2dabe45ce3b25/tools/binary_size/diagnose_bloat.py

Issue 732077 has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9da23f839fbd8606189e749cb92fb707cb9f4bce

commit 9da23f839fbd8606189e749cb92fb707cb9f4bce
Author: Eric Stevenson <estevenson@chromium.org>
Date: Wed Jun 14 15:06:45 2017

Remove patch size estimation from Android perf builders.

Mostly a revert of eca15296bf0f928789c471f134c7cc9f8e34452d.

Patch size estimation is too slow for builders. It might be turned on
again in the future on testers.

BUG= 695188 ,  726718 

Change-Id: I4efde4a1585e17833a537ce76a7d7a72c79d0fe8
Reviewed-on: https://chromium-review.googlesource.com/531584
Reviewed-by: John Budorick <jbudorick@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>

[modify] https://crrev.com/9da23f839fbd8606189e749cb92fb707cb9f4bce/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json
[modify] https://crrev.com/9da23f839fbd8606189e749cb92fb707cb9f4bce/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder.json
[modify] https://crrev.com/9da23f839fbd8606189e749cb92fb707cb9f4bce/scripts/slave/recipe_modules/chromium_android/tests/resource_sizes.expected/basic.json
[modify] https://crrev.com/9da23f839fbd8606189e749cb92fb707cb9f4bce/scripts/slave/recipe_modules/chromium_android/tests/resource_sizes.py
[modify] https://crrev.com/9da23f839fbd8606189e749cb92fb707cb9f4bce/scripts/slave/recipes/android/builder.py
[modify] https://crrev.com/9da23f839fbd8606189e749cb92fb707cb9f4bce/scripts/slave/recipe_modules/chromium_android/api.py

Status: WontFix (was: Assigned)
Going to close this one, we've got static initializer counting/alerts (w/out the slow version) and it doesn't seem worth the effort to add patch size estimation.

Sign in to add a comment