Issue metadata
Sign in to add a comment
|
Navigating back from Request Desktop Site of news.google.com is not updating the content area properly. |
||||||||||||||||||||||
Issue descriptionApp Version: 60.0.3112.0 canary iOS Version: 10.3.3, 9.3.5 Device: iPhone7 plus, iPhone6 plus URL: news.google.com Steps to reproduce: 1. Launch Google Chrome Canary 2. Open news.google.com 3. Menu → Request Desktop Site 4. Tap on back arrow on toolbar Observed results: Observe that URL is updated but content area still shows desktop website. Tapping further on back arrow takes to NTP but still news.google.com content area is displayed in NTP Expected results: Navigating back and forth should update content area correctly. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NO, Safari: NO Bug reproducible on current stable build (App Version, iOS Version): M58 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M59.0.3071.73 beta NO Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKuaS1BdHhHWER0eTg/view
,
May 31 2017
liaoyuke@ could you please take a look? Thanks!
,
May 31 2017
,
Jun 15 2017
Also Grey bar is shown at the top. when you Tap Back button twice -> Tap Forward https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLOFY2RUVOTF9rUW8/view
,
Jun 20 2017
Hi Yuke, Can you please take a look asap and let us know if this is related to your refactoring of RDS? The grey space shown in comment #4 around 0.17 in the video may be RBS, so updating the bug status. If you can check this today, please assign this bug to someone that can. Thanks,
,
Jun 20 2017
,
Jun 21 2017
This is the culprit CL: https://codereview.chromium.org/2811073005/, It's very interesting that this only happens on devices, not sure if there is a bug with WKWebView's |setCustomUserAgent| method. The culprit CL doesn't affect the functionalities at all, I'll revert it first and then investigate more.
,
Jun 21 2017
cc Eugene. I just verified |setCustomUserAgent| and |loadCurrentURL| are called correctly, I'm getting lost in how this could happen only on news.google.com on devices. Anyway, I'm going to revert the culprit CL first.
,
Jun 21 2017
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad432d3722e00a5914f9be006599237fc7cf896c commit ad432d3722e00a5914f9be006599237fc7cf896c Author: Yuke Liao <liaoyuke@chromium.org> Date: Wed Jun 21 22:44:00 2017 Revert Replace requirePageReconstruction with setCustomUserAgent" This reverts commit b1688d0107c311a09b0bfb03df0b81ab9b21afc0, because [WKWebView setCustomerUserAgent] doesn't seem to work on news.google.com on devices. when user goes to news.google.com and requests desktop version of the page and then goes back to mobile version, the page doesn't refresh. The CL has no visible user impact as the reverted CL was only meant to improve performance when navigating between desktop and mobile sites tabs. Bug: 726714 Change-Id: I804aeb7620e903c730edd4c951e0ab2564bea21e Reviewed-on: https://chromium-review.googlesource.com/542962 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#481337} [modify] https://crrev.com/ad432d3722e00a5914f9be006599237fc7cf896c/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/ad432d3722e00a5914f9be006599237fc7cf896c/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/ad432d3722e00a5914f9be006599237fc7cf896c/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/ad432d3722e00a5914f9be006599237fc7cf896c/ios/web/web_state/web_view_internal_creation_util.h [modify] https://crrev.com/ad432d3722e00a5914f9be006599237fc7cf896c/ios/web/web_state/web_view_internal_creation_util.mm [modify] https://crrev.com/ad432d3722e00a5914f9be006599237fc7cf896c/ios/web/web_view_creation_util.mm
,
Jun 21 2017
,
Jun 21 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 22 2017
Verified on chrome version 61.0.3138.0 canary on iPhone 6s plus with iOS 10.3.1, iPhone 7 with iOS 10.3.2, following the steps mentioned in comment #0. At Step 4, mobile version of news.google.com is displayed and on tapping further back arrow NTP is displayed. Looks good.
,
Jun 22 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79af28df593a651affdb2836d4b8c665a2208296 commit 79af28df593a651affdb2836d4b8c665a2208296 Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Jun 22 21:36:09 2017 Revert Replace requirePageReconstruction with setCustomUserAgent" This reverts commit b1688d0107c311a09b0bfb03df0b81ab9b21afc0, because [WKWebView setCustomerUserAgent] doesn't seem to work on news.google.com on devices. when user goes to news.google.com and requests desktop version of the page and then goes back to mobile version, the page doesn't refresh. The CL has no visible user impact as the reverted CL was only meant to improve performance when navigating between desktop and mobile sites tabs. Bug: 726714 Change-Id: I804aeb7620e903c730edd4c951e0ab2564bea21e Reviewed-on: https://chromium-review.googlesource.com/542962 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#481337} Review-Url: https://codereview.chromium.org/2956513003 . Cr-Commit-Position: refs/branch-heads/3112@{#445} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/79af28df593a651affdb2836d4b8c665a2208296/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/79af28df593a651affdb2836d4b8c665a2208296/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/79af28df593a651affdb2836d4b8c665a2208296/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/79af28df593a651affdb2836d4b8c665a2208296/ios/web/web_state/web_view_internal_creation_util.h [modify] https://crrev.com/79af28df593a651affdb2836d4b8c665a2208296/ios/web/web_state/web_view_internal_creation_util.mm [modify] https://crrev.com/79af28df593a651affdb2836d4b8c665a2208296/ios/web/web_view_creation_util.mm
,
Jun 28 2017
Verified on: Chrome Version: 60.0.3112.50 Beta Device: iPhone 6s Plus, iPhone6 Plus iOS Version: 10.3.1,11.0 Navigating back takes to mobile version of news.google.com and tapping on back arrow further, NTP is displayed. Working as expected. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by srikanthg@chromium.org
, May 30 2017