FeedbackCollectorTest#testGatheringOfDataNoScreenshot failing reliably on Marshmallow 64 bit Tester |
||||||||||
Issue descriptionorg.chromium.chrome.browser.feedback.FeedbackCollectorTest#testGatheringOfDataNoScreenshot is failing reliably on Marshmallow 64 bit Tester. First failure: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/12487 Sample logs: I 456.855s run_tests_on_device(00c2ca8f80789d2a) INSTRUMENTATION_STATUS: id=AndroidJUnitRunner I 456.855s run_tests_on_device(00c2ca8f80789d2a) INSTRUMENTATION_STATUS: test=testGatheringOfDataNoScreenshot I 456.855s run_tests_on_device(00c2ca8f80789d2a) INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.feedback.FeedbackCollectorTest I 456.855s run_tests_on_device(00c2ca8f80789d2a) INSTRUMENTATION_STATUS: stack=java.lang.AssertionError: Result should not be ready after connectivity data. I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.Assert.fail(Assert.java:88) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.Assert.assertTrue(Assert.java:41) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.Assert.assertFalse(Assert.java:64) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.chromium.chrome.browser.feedback.FeedbackCollectorTest.testGatheringOfDataNoScreenshot(FeedbackCollectorTest.java:370) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at java.lang.reflect.Method.invoke(Native Method) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:59) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.chromium.chrome.test.ChromeActivityTestRule$2.evaluate(ChromeActivityTestRule.java:66) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.rules.RunRules.evaluate(RunRules.java:20) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:135) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:36) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.Suite.runChild(Suite.java:128) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.Suite.runChild(Suite.java:27) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) I 456.855s run_tests_on_device(00c2ca8f80789d2a) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) I 456.856s run_tests_on_device(00c2ca8f80789d2a) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) I 456.856s run_tests_on_device(00c2ca8f80789d2a) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) I 456.856s run_tests_on_device(00c2ca8f80789d2a) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) I 456.856s run_tests_on_device(00c2ca8f80789d2a) I 456.856s run_tests_on_device(00c2ca8f80789d2a) INSTRUMENTATION_STATUS: current=1 I 456.856s run_tests_on_device(00c2ca8f80789d2a) INSTRUMENTATION_STATUS_CODE: -2 I 456.856s run_tests_on_device(00c2ca8f80789d2a) INSTRUMENTATION_RESULT: stream= I 456.856s run_tests_on_device(00c2ca8f80789d2a)
,
May 26 2017
,
May 26 2017
,
May 26 2017
Have a fix in CQ here: https://codereview.chromium.org/2906903002/
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac576561b36502cca1a685ab92d3ef9f03546154 commit ac576561b36502cca1a685ab92d3ef9f03546154 Author: ymalik <ymalik@chromium.org> Date: Fri May 26 15:58:37 2017 Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot This test was added in https://codereview.chromium.org/2897323002/ but was making incorrect assets. That is, when we're not expecting screeshots, the results from the connectivity task should trigger the test callback. It was passing locally because of timing. The things we were checking for in the tests would be set once FeedbackCollector#maybePostResult would post task a call to the callback in the test. The incorrect assert would be made before the callback would get called. TBR=nyquist@chromium.org BUG= 726704 Review-Url: https://codereview.chromium.org/2906903002 Cr-Commit-Position: refs/heads/master@{#475015} [modify] https://crrev.com/ac576561b36502cca1a685ab92d3ef9f03546154/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java [modify] https://crrev.com/ac576561b36502cca1a685ab92d3ef9f03546154/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
,
May 26 2017
It's passing in https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/12503
,
May 29 2017
,
May 29 2017
,
May 29 2017
Opened for merge.
,
May 29 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37b290974a762400695340bb7ac4585087e02b85 commit 37b290974a762400695340bb7ac4585087e02b85 Author: Yash Malik <ymalik@google.com> Date: Thu Jun 01 15:11:06 2017 Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot This test was added in https://codereview.chromium.org/2897323002/ but was making incorrect assets. That is, when we're not expecting screeshots, the results from the connectivity task should trigger the test callback. It was passing locally because of timing. The things we were checking for in the tests would be set once FeedbackCollector#maybePostResult would post task a call to the callback in the test. The incorrect assert would be made before the callback would get called. TBR=nyquist@chromium.org BUG= 726704 Review-Url: https://codereview.chromium.org/2906903002 Cr-Original-Commit-Position: refs/heads/master@{#475015} Review-Url: https://codereview.chromium.org/2915063002 . Cr-Commit-Position: refs/branch-heads/3112@{#90} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/37b290974a762400695340bb7ac4585087e02b85/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java [modify] https://crrev.com/37b290974a762400695340bb7ac4585087e02b85/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
,
Jun 1 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by guidou@chromium.org
, May 26 2017