New issue
Advanced search Search tips

Issue 726702 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Implement SetWindowTextAndCaretPos and SetCaretPos on iOS

Project Member Reported by rohitrao@chromium.org, May 26 2017

Issue description

Neither of these functions set the caret position on iOS.  Use the UITextInput APIs to set the selectedTextRange instead of ignoring that argument.
 
Blocking: 738559
Blocking: -738559
This is not related to determination of cursor position (the bug added earlier as blocking).
Cc: rohitrao@chromium.org
Owner: stkhapugin@chromium.org
Status: Started (was: Assigned)
I don't think we *really* need these methods, because we already have the desired behavior, but I guess it's good to be consistent on different platforms. 

Uploaded https://chromium-review.googlesource.com/c/chromium/src/+/1165085.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94c879408d7f78f7401ed3251196a69e67044bc8

commit 94c879408d7f78f7401ed3251196a69e67044bc8
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Aug 20 10:45:27 2018

Implement SetWindowTextAndCaretPos and SetCaretPos on iOS.

Implements the two methods on iOS.

Bug:  726702 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib2a8a40be00c555096ca79915654d62e6ee1ac77
Reviewed-on: https://chromium-review.googlesource.com/1165085
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584400}
[modify] https://crrev.com/94c879408d7f78f7401ed3251196a69e67044bc8/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

Status: Fixed (was: Started)

Sign in to add a comment