New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726676 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression:Three dot menu icon is missing for adding a printer with lengthy names in Md-settings/cupsPrinters page.

Project Member Reported by rkalavakuntla@chromium.org, May 26 2017

Issue description

Chrome Version:60.0.3110.0/9590.0.0 Dev-channel Daisy,Candy and Peppy 
OS:Chrome

What steps will reproduce the problem?
(1)Sign in to user ->Navigate to chrome://md-settings/cupsPrinters ->click on Add Printer
(2)Add a printer manually by specifying a lengthy name in the Name field.
(3)After adding a sample printer with lengthy name,Press tab and Observe the missing of three dot menu 

Actual:Three dot menu icon is missing for adding a printer with lengthy names.
Expected:Should be able to get the three dot menu icon for adding a printer with lengthy names.

This is a Non-Regression issue seen from M-59.

Note:
1.Issue is not seen in Windows,Linux OS
2.Issue is seen in Latest M-60 also

@stevenjb :Please confirm the issue.

 
Actual.png
50.2 KB View Download
Actual.webm
1.2 MB View Download
Summary: Non-Regression:Three dot menu icon is missing for adding a printer with lengthy names in Md-settings/cupsPrinters page. (was: Regression:Three dot menu icon is missing for adding a printer with lengthy names in Md-settings/cupsPrinters page.)
Cc: x...@chromium.org stevenh@chromium.org
Owner: x...@chromium.org
Status: Started (was: Assigned)
xdai@ - There are 
Cc: -stevenh@chromium.org
Owner: steve...@chromium.org
Sorry, in the process of examining the problem I realized it would be easier to just fix it :) CL here:

https://codereview.chromium.org/2906893003/

Comment 5 by x...@chromium.org, May 26 2017

Cc: weifangsun@chromium.org shibasheikh@chromium.org
shibasheikh@: The CL in #4 caused some UI change. I talked with Weifang, and she is fine with the change. FYI the before and after screenshots of the CL in place. 
before.png
18.7 KB View Download
after2.png
18.8 KB View Download
Components: Internals>Printing>CUPS
xdai@ - Thanks for adding the screenshots. Glad there are no UX concerns - the new UI is now consistent with the rest of Settings which is something the Settings team has been working towards (consistency throughout the subpages).

Project Member

Comment 8 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9481b6417f18f946c21e1a2049c7052caf0c8e7

commit e9481b6417f18f946c21e1a2049c7052caf0c8e7
Author: stevenjb <stevenjb@chromium.org>
Date: Tue May 30 20:57:09 2017

Settings: Printers: Cleanup layout and fix for long names

BUG= 726676 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2906893003
Cr-Commit-Position: refs/heads/master@{#475665}

[modify] https://crrev.com/e9481b6417f18f946c21e1a2049c7052caf0c8e7/chrome/browser/resources/settings/printing_page/cups_printers_list.html

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment