Non-Regression:Three dot menu icon is missing for adding a printer with lengthy names in Md-settings/cupsPrinters page. |
||||||||
Issue descriptionChrome Version:60.0.3110.0/9590.0.0 Dev-channel Daisy,Candy and Peppy OS:Chrome What steps will reproduce the problem? (1)Sign in to user ->Navigate to chrome://md-settings/cupsPrinters ->click on Add Printer (2)Add a printer manually by specifying a lengthy name in the Name field. (3)After adding a sample printer with lengthy name,Press tab and Observe the missing of three dot menu Actual:Three dot menu icon is missing for adding a printer with lengthy names. Expected:Should be able to get the three dot menu icon for adding a printer with lengthy names. This is a Non-Regression issue seen from M-59. Note: 1.Issue is not seen in Windows,Linux OS 2.Issue is seen in Latest M-60 also @stevenjb :Please confirm the issue.
,
May 26 2017
xdai@ - There are
,
May 26 2017
,
May 26 2017
Sorry, in the process of examining the problem I realized it would be easier to just fix it :) CL here: https://codereview.chromium.org/2906893003/
,
May 26 2017
shibasheikh@: The CL in #4 caused some UI change. I talked with Weifang, and she is fine with the change. FYI the before and after screenshots of the CL in place.
,
May 26 2017
,
May 30 2017
xdai@ - Thanks for adding the screenshots. Glad there are no UX concerns - the new UI is now consistent with the rest of Settings which is something the Settings team has been working towards (consistency throughout the subpages).
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9481b6417f18f946c21e1a2049c7052caf0c8e7 commit e9481b6417f18f946c21e1a2049c7052caf0c8e7 Author: stevenjb <stevenjb@chromium.org> Date: Tue May 30 20:57:09 2017 Settings: Printers: Cleanup layout and fix for long names BUG= 726676 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2906893003 Cr-Commit-Position: refs/heads/master@{#475665} [modify] https://crrev.com/e9481b6417f18f946c21e1a2049c7052caf0c8e7/chrome/browser/resources/settings/printing_page/cups_printers_list.html
,
May 30 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rkalavakuntla@chromium.org
, May 26 2017