New issue
Advanced search Search tips

Issue 726666 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 770175



Sign in to add a comment

Password manager does not fill previously invisible form

Project Member Reported by melandory@chromium.org, May 26 2017

Issue description

Web site: https://gramista.com/

Password manager detects hidden form on a page (output from chrome://password-manager-internals):
Form is a password form: {
Action : https://gramista.com/ ,
New password element : password-new ,
Origin : https://gramista.com/ ,
PSL match : false,
Password element : password ,
Password generated : false,
Scheme : HTML ,
Signon realm : https://gramista.com/ ,
Times used : 0,
Username element : 
}

When "Sign-in" button is clicked, form becomes visible to the user, but the password manager doesn't detect this.
 

Comment 1 by vabr@chromium.org, Jun 8 2017

Labels: Hotlist-Polish
Summary: Password manager does not fill previously invisible form (was: Password manager is not activate for unvisible form)
melandory@: I'm guessing that "activated" means "did not fill". Is that correct?

Owner is set, but status is Available. Therefore setting to Assigned; kolos@ -- please feel free to disown and mark Available if you cannot work on this in the near future.

Comment 2 by kolos@chromium.org, Jun 9 2017

Tested in beta (M60). Autofill and filling on username field doesn't work, but it works if user clicks on password field (both username and password fields are filled). 

So, it's not perfect but possible to fill credentials. Keep open as an example for further improvements.


Comment 3 by kolos@chromium.org, Nov 3 2017

Owner: ----

Comment 4 by kolos@chromium.org, Nov 3 2017

Cc: kolos@chromium.org

Comment 5 by kolos@chromium.org, Jan 26 2018

Blocking: 770175
All password fields on gramista.com are annotated with `autocomplete="new-password"`. Therefore, this is considered a sign-up form and not a log-in form [1].
There are tests that ensure that such fields are not filled which makes this case pretty easy to reproduce [2].

On this particular site, this behavior might be a copy-and-paste mistake as all passwords fields have the same id. They are in different pop-up containers though.


[1] https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands
[2] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/password_manager_browsertest.cc?dr=C&q=AutofillSuggestionsForChangePwdWithEmptyNamesButOnlyNewPwdField&sq=package:chromium&l=2761

Sign in to add a comment