New issue
Advanced search Search tips

Issue 726659 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"AutofillInteractiveTest.AutofillFormWithRepeatedField" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 26 2017

Issue description

"AutofillInteractiveTest.AutofillFormWithRepeatedField" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQAsSBUZsYWtlIjVBdXRvZmlsbEludGVyYWN0aXZlVGVzdC5BdXRvZmlsbEZvcm1XaXRoUmVwZWF0ZWRGaWVsZAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by guidou@chromium.org, May 26 2017

Components: UI>Browser>Autofill
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e96e8723fa7c5afa07a806eabc14c009373ba72

commit 1e96e8723fa7c5afa07a806eabc14c009373ba72
Author: guidou <guidou@chromium.org>
Date: Fri May 26 12:08:44 2017

Disable flaky AutofillInteractiveTest tests on Windows.

BUG= 726659 
TBR=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2907633003
Cr-Commit-Position: refs/heads/master@{#474985}

[modify] https://crrev.com/1e96e8723fa7c5afa07a806eabc14c009373ba72/chrome/browser/autofill/autofill_interactive_uitest.cc

Comment 3 by guidou@chromium.org, May 26 2017

Labels: -Sheriff-Chromium

Comment 4 by guidou@chromium.org, May 26 2017

Labels: -Pri-1 Pri-2
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
estade@: Can you take a look or help find a better owner for this?

Comment 5 by est...@chromium.org, May 30 2017

Owner: ma...@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/522146e8024f81aff5a7c076f5a819aec719ed99

commit 522146e8024f81aff5a7c076f5a819aec719ed99
Author: Greg Thompson <grt@chromium.org>
Date: Thu Oct 05 00:02:06 2017

Deflake ui_controls::SendMouseMove on Windows.

On Windows, SendMouseMove must transform a point in screen coordinates
into the range (0..2^16-1) for consumption by SendInput. Windows then
converts this back to screen coordinates. This change rounds up rather
than down in the initial conversion so that Windows lands on the correct
point when it seemly truncates.

Previously, we'd see off-by-one errors from time to time. While this may
seem insignificant at first blush, it's problematic when SendMouseMove
is called to move the mouse to a point where it already resides. No
events are generated by SendInput in this case, so the hook proc will
never be called. This shouldn't be a problem since SendMouseMove detects
this case and short-circuits the request. With the ob1, however,
SendMouseMove thinks it needs to move the mouse by one point, yet the
bad math results in a call to SendInput to move the mouse to its current
position. This makes tests timeout and all of us sad.

BUG= 390564 , 639940 , 710436 , 726659 , 728488 , 764415 
R=mathp@chromium.org, sky@chromium.org

Change-Id: I1daebe8281db0a799ef7266c3c1765de65580f03
Reviewed-on: https://chromium-review.googlesource.com/686898
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506574}
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/autofill/autofill_interactive_uitest.cc
[add] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/ui/send_mouse_move_uitest_win.cc
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/test/BUILD.gn
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/ui/base/test/ui_controls_internal_win.cc

Comment 7 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Assigned)

Comment 8 by ma...@chromium.org, May 11 2018

Status: WontFix (was: Untriaged)

Sign in to add a comment