New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726622 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: !v8::internal::FLAG_enable_slow_asserts || (object->IsJSFunction()) in objects-i

Project Member Reported by ClusterFuzz, May 26 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6078170360184832

Fuzzer: inferno_js_fuzzer_c
Job Type: linux_asan_d8_v8_arm64_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !v8::internal::FLAG_enable_slow_asserts || (object->IsJSFunction()) in objects-i
  
Sanitizer: address (ASAN)

Regressed: V8: 44701:44702

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6078170360184832


Issue manually filed by: ishell

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 26 2017

Detailed report: https://clusterfuzz.com/testcase?key=4727886732066816

Fuzzer: inferno_js_fuzzer_c
Job Type: linux_asan_d8
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  map()->is_callable() in objects-debug.cc
  
Sanitizer: address (ASAN)

Regressed: V8: 44701:44702

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4727886732066816


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

Comment 2 by ishell@chromium.org, May 26 2017

Cc: kozyatinskiy@chromium.org dgozman@chromium.org yangguo@chromium.org
Owner: ishell@chromium.org
Status: Assigned (was: Untriaged)
CF points to 54271c21e2860273abd6018c398b04f672ef2615.
Project Member

Comment 3 by sheriffbot@chromium.org, May 26 2017

Labels: M-60
Project Member

Comment 4 by sheriffbot@chromium.org, May 26 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, May 26 2017

Labels: Pri-1

Comment 6 by ishell@chromium.org, May 26 2017

The console CL just let the tests go further than just hitting undefined reference at the first line.

The fix is on the way: https://chromium-review.googlesource.com/c/516626/
Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fdd8d15155a6e79af686a2b02eb97eaf86a45842

commit fdd8d15155a6e79af686a2b02eb97eaf86a45842
Author: Igor Sheludko <ishell@chromium.org>
Date: Fri May 26 15:21:32 2017

[runtime] Remove unnecessary casts of species constructor.

... which caused assertion failures in --enable-slow-asserts mode.
The surrounding code treated the constructor value properly so regression
test is not necessary.

Bug:  chromium:726622 
Change-Id: Icd43d9117a1125bec8feca8eca5708993de2c3ef
Reviewed-on: https://chromium-review.googlesource.com/516626
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45543}
[modify] https://crrev.com/fdd8d15155a6e79af686a2b02eb97eaf86a45842/src/builtins/builtins-arraybuffer.cc
[modify] https://crrev.com/fdd8d15155a6e79af686a2b02eb97eaf86a45842/src/execution.cc
[modify] https://crrev.com/fdd8d15155a6e79af686a2b02eb97eaf86a45842/src/execution.h
[modify] https://crrev.com/fdd8d15155a6e79af686a2b02eb97eaf86a45842/src/objects.cc
[modify] https://crrev.com/fdd8d15155a6e79af686a2b02eb97eaf86a45842/src/objects.h
[modify] https://crrev.com/fdd8d15155a6e79af686a2b02eb97eaf86a45842/src/runtime/runtime-regexp.cc

Comment 8 by ishell@chromium.org, May 26 2017

Status: Fixed (was: Assigned)

Comment 9 by ishell@chromium.org, May 26 2017

Cc: mstarzinger@chromium.org ishell@chromium.org
 Issue 726256  has been merged into this issue.
 Issue 724615  has been merged into this issue.
Project Member

Comment 11 by ClusterFuzz, May 27 2017

ClusterFuzz has detected this issue as fixed in range 45543:45544.

Detailed report: https://clusterfuzz.com/testcase?key=4727886732066816

Fuzzer: inferno_js_fuzzer_c
Job Type: linux_asan_d8
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  map()->is_callable() in objects-debug.cc
  
Sanitizer: address (ASAN)

Regressed: V8: 44701:44702
Fixed: V8: 45543:45544

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4727886732066816


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, May 27 2017

ClusterFuzz has detected this issue as fixed in range 45542:45543.

Detailed report: https://clusterfuzz.com/testcase?key=6078170360184832

Fuzzer: inferno_js_fuzzer_c
Job Type: linux_asan_d8_v8_arm64_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !v8::internal::FLAG_enable_slow_asserts || (object->IsJSFunction()) in objects-i
  
Sanitizer: address (ASAN)

Regressed: V8: 44701:44702
Fixed: V8: 45542:45543

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6078170360184832


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by sheriffbot@chromium.org, May 27 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
 Issue 727056  has been merged into this issue.
 Issue 727153  has been merged into this issue.
Project Member

Comment 16 by ClusterFuzz, May 29 2017

Labels: OS-Windows
Project Member

Comment 17 by ClusterFuzz, May 29 2017

Labels: OS-Mac
Labels: Merge-Request-60
Project Member

Comment 19 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Project Member

Comment 21 by sheriffbot@chromium.org, Jun 12 2017

Cc: awhalley@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 23 by sheriffbot@chromium.org, Jun 15 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-60
Already merged.
Labels: -ReleaseBlock-Stable
Project Member

Comment 26 by ClusterFuzz, Jul 14 2017

Labels: Needs-Feedback
ClusterFuzz testcase 5407365456461824 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
I rerun a redo and according to https://bugs.chromium.org/p/chromium/issues/detail?id=727153#c2 the issue is still fixed.
Labels: -Needs-Feedback
Looks like something weird happened with testcase doing fixed testing. redo shows it is indeed fixed.
Project Member

Comment 29 by sheriffbot@chromium.org, Sep 2 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment