New issue
Advanced search Search tips

Issue 726614 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add CDM session key status system code UMA

Project Member Reported by xhw...@chromium.org, May 26 2017

Issue description

System code associated with key status provides extra information on the CDM status (e.g. internal error). We should add UMA to record the system code to help understand real world error data. See issue 690696 for the context.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64fe7102b48b16cacf19b2d640199dd6c366c716

commit 64fe7102b48b16cacf19b2d640199dd6c366c716
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Sat May 27 03:55:48 2017

media: Add UMA for CDM session key status system code

System code associated with key status provides extra information on the
CDM status (e.g. error).

BUG= 726614 

Change-Id: Ic65d9807045f455bcd58b6caeab9e9c79ee18001
Reviewed-on: https://chromium-review.googlesource.com/516433
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475232}
[modify] https://crrev.com/64fe7102b48b16cacf19b2d640199dd6c366c716/media/blink/webcontentdecryptionmodulesession_impl.cc
[modify] https://crrev.com/64fe7102b48b16cacf19b2d640199dd6c366c716/tools/metrics/histograms/histograms.xml

Comment 2 by xhw...@chromium.org, May 30 2017

Labels: Merge-Request-60
The CL missed the branch point and we'd like to start collecting data as early as possible. Request merge to M60.
Project Member

Comment 3 by sheriffbot@chromium.org, May 30 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the fix. 

Please confirm whether the fix is verified in canary. If yes, merge to 3112 branch before 4.00 PM PST(05/31) to make it to next release.
Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ff33f9b12a695f7458372917efcf69dbed21d5

commit d2ff33f9b12a695f7458372917efcf69dbed21d5
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed May 31 00:45:17 2017

media: Add UMA for CDM session key status system code

System code associated with key status provides extra information on the
CDM status (e.g. error).

BUG= 726614 

Change-Id: Ic65d9807045f455bcd58b6caeab9e9c79ee18001
Reviewed-on: https://chromium-review.googlesource.com/516433
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#475232}(cherry picked from commit 64fe7102b48b16cacf19b2d640199dd6c366c716)
Reviewed-on: https://chromium-review.googlesource.com/518424
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#45}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/d2ff33f9b12a695f7458372917efcf69dbed21d5/media/blink/webcontentdecryptionmodulesession_impl.cc
[modify] https://crrev.com/d2ff33f9b12a695f7458372917efcf69dbed21d5/tools/metrics/histograms/histograms.xml

Comment 6 by xhw...@chromium.org, May 31 2017

Status: Fixed (was: Started)

Sign in to add a comment