New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726601 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: release_count >= release_count_ in command_buffer_service.cc

Project Member Reported by ClusterFuzz, May 26 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6116133039243264

Fuzzer: libfuzzer_gpu_angle_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  release_count >= release_count_ in command_buffer_service.cc
  base::debug::DebugBreak
  gpu::CommandBufferService::SetReleaseCount
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=474392:474795

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6116133039243264


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org
Components: Internals>GPU>Internals
Labels: M-60 Test-Predator-Correct-CLs
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: Antoine Labour
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/e7e2da67f4d4193974751e59ab69325bb72195aa
Time: Thu May 25 00:28:26 2017
Files command_buffer_direct.cc, command_buffer_service.cc are changed in this cl (and is part of stack frame #11, "gpu::CommandBufferDirect::OnFenceSyncRelease")
Minimum distance from crash line to modified line: 15. (file: command_buffer_service.cc, crashed on: 125, modified: 110).

@Antonie Labour -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by piman@chromium.org, Jun 1 2017

Owner: piman@chromium.org
Status: Started (was: Untriaged)
Won't happen if you don't actually cc me...
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75cec4c72223c895e6a3593faa46b3171905215d

commit 75cec4c72223c895e6a3593faa46b3171905215d
Author: Antoine Labour <piman@chromium.org>
Date: Fri Jun 02 22:52:56 2017

Remove invalid assert in CommandBufferService

The release count is set with data from an untrusted client, so we can't assume
it's monotonic on the service side.

Bug:  726601 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icd0a8a5915b6cef4274f4c13df3332cba660c9f3
Reviewed-on: https://chromium-review.googlesource.com/522904
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476825}
[modify] https://crrev.com/75cec4c72223c895e6a3593faa46b3171905215d/gpu/command_buffer/service/command_buffer_service.cc

Project Member

Comment 5 by ClusterFuzz, Jun 3 2017

ClusterFuzz has detected this issue as fixed in range 476797:476834.

Detailed report: https://clusterfuzz.com/testcase?key=6116133039243264

Fuzzer: libFuzzer_gpu_angle_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  release_count >= release_count_ in command_buffer_service.cc
  base::debug::DebugBreak
  gpu::CommandBufferService::SetReleaseCount
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=474392:474795
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=476797:476834

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6116133039243264


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jun 3 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6116133039243264 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment