New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726600 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 692860
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK hitting in content::AttachRequestBodyBlobDataHandles

Project Member Reported by wfh@chromium.org, May 26 2017

Issue description

Chrome Version: 60.0.3112.0 git rev ce2e11f2565db306765cc6f6412cf5bfb158fb70
OS: Win10

What steps will reproduce the problem?
(1) load chrome
(2) browse to www.google.com
(3)

What is the expected result?

do not hit dcheck

What happens instead?

hit dcheck

Please use labels and text to provide additional information.

c:\src\chromium\src>type out\goma32\args.gn
is_debug = false
is_component_build = false
target_cpu="x86"
use_goma = true
symbol_level = 2
is_win_fastlink = true
goma_dir = "C:\src\goma\goma-win64"
is_clang = true
is_chrome_branded = true
dcheck_always_on = true
enable_nacl = false


0:024> k
 # ChildEBP RetAddr  
00 0aead6b0 106f14ca chrome_fda0000!base::debug::BreakDebugger+0xc [C:\src\chromium\src\base\debug\debugger_win.cc @ 21]
01 0aeadb30 1008ae62 chrome_fda0000!logging::LogMessage::~LogMessage+0x46a [C:\src\chromium\src\base\logging.cc @ 783]
02 0aeadc10 1020f6f6 chrome_fda0000!content::AttachRequestBodyBlobDataHandles+0xdf [C:\src\chromium\src\content\browser\blob_storage\chrome_blob_storage_context.cc @ 212]
03 0aeadd50 1020e3b4 chrome_fda0000!content::ResourceDispatcherHostImpl::ContinuePendingBeginRequest+0x3a4 [C:\src\chromium\src\content\browser\loader\resource_dispatcher_host_impl.cc @ 1307]
04 0aeadee8 1020df07 chrome_fda0000!content::ResourceDispatcherHostImpl::BeginRequest+0x474 [C:\src\chromium\src\content\browser\loader\resource_dispatcher_host_impl.cc @ 1186]
05 0aeae014 1020d72b chrome_fda0000!content::ResourceDispatcherHostImpl::OnRequestResourceInternal+0x173 [C:\src\chromium\src\content\browser\loader\resource_dispatcher_host_impl.cc @ 904]
06 0aeae058 1020d6b0 chrome_fda0000!content::ResourceDispatcherHostImpl::OnRequestResource+0x51 [C:\src\chromium\src\content\browser\loader\resource_dispatcher_host_impl.cc @ 876]
07 0aeae358 1020d457 chrome_fda0000!IPC::MessageT<ResourceHostMsg_RequestResource_Meta, std::tuple<int, int, content::ResourceRequest>, void>::Dispatch<content::ResourceDispatcherHostImpl,content::ResourceDispatcherHostImpl,content::ResourceRequesterInfo,void (content::ResourceDispatcherHostImpl::*)(content::ResourceRequesterInfo *, int, int, const content::ResourceRequest &) __attribute__((thiscall))>+0xfa [C:\src\chromium\src\ipc\ipc_message_templates.h @ 120]
08 0aeae498 102192ff chrome_fda0000!content::ResourceDispatcherHostImpl::OnMessageReceived+0x36f [C:\src\chromium\src\content\browser\loader\resource_dispatcher_host_impl.cc @ 837]
09 0aeae574 0fff388b chrome_fda0000!content::ResourceMessageFilter::OnMessageReceived+0xcf [C:\src\chromium\src\content\browser\loader\resource_message_filter.cc @ 68]
0a 0aeae644 0fff37bf chrome_fda0000!content::BrowserMessageFilter::Internal::DispatchMessageW+0x2d [C:\src\chromium\src\content\public\browser\browser_message_filter.cc @ 86]
0b 0aeae6a4 10b1c90f chrome_fda0000!content::BrowserMessageFilter::Internal::OnMessageReceived+0x1f1 [C:\src\chromium\src\content\public\browser\browser_message_filter.cc @ 66]
0c 0aeae6bc 10b1c8e9 chrome_fda0000!IPC::`anonymous namespace'::TryFiltersImpl+0x1c [c:\src\chromium\src\ipc\message_filter_router.cc @ 22]
0d 0aeae6cc 10b14397 chrome_fda0000!IPC::MessageFilterRouter::TryFilters+0x3b [c:\src\chromium\src\ipc\message_filter_router.cc @ 87]
0e 0aeae7c0 10b145e8 chrome_fda0000!IPC::ChannelProxy::Context::TryFilters+0x5f [C:\src\chromium\src\ipc\ipc_channel_proxy.cc @ 87]
0f 0aeae7d4 10b0eafe chrome_fda0000!IPC::ChannelProxy::Context::OnMessageReceived+0x10 [C:\src\chromium\src\ipc\ipc_channel_proxy.cc @ 122]
10 0aeae84c 10b1b26e chrome_fda0000!IPC::ChannelMojo::OnMessageReceived+0x114 [c:\src\chromium\src\ipc\ipc_channel_mojo.cc @ 414]
11 0aeae954 10b1d341 chrome_fda0000!IPC::internal::MessagePipeReader::Receive+0x1aa [C:\src\chromium\src\ipc\ipc_message_pipe_reader.cc @ 109]
12 0aeae9dc 10b1b421 chrome_fda0000!IPC::mojom::ChannelStubDispatch::Accept+0x2c5 [C:\src\chromium\src\out\goma32\gen\ipc\ipc.mojom.cc @ 260]
13 0aeae9ec 106d1a35 chrome_fda0000!IPC::mojom::ChannelStub<mojo::RawPtrImplRefTraits<IPC::mojom::Channel> >::Accept+0x13 [C:\src\chromium\src\out\goma32\gen\ipc\ipc.mojom.h @ 276]
14 0aeaeacc 106d6189 chrome_fda0000!mojo::InterfaceEndpointClient::HandleValidatedMessage+0x211 [C:\src\chromium\src\mojo\public\cpp\bindings\lib\interface_endpoint_client.cc @ 408]
15 0aeaeba4 106d279a chrome_fda0000!mojo::FilterChain::Accept+0x7f [C:\src\chromium\src\mojo\public\cpp\bindings\lib\filter_chain.cc @ 40]
16 0aeaec74 10b17532 chrome_fda0000!mojo::InterfaceEndpointClient::HandleIncomingMessage+0x68 [C:\src\chromium\src\mojo\public\cpp\bindings\lib\interface_endpoint_client.cc @ 293]
17 0aeaedbc 106d6189 chrome_fda0000!IPC::`anonymous namespace'::ChannelAssociatedGroupController::Accept+0x1a8 [c:\src\chromium\src\ipc\ipc_mojo_bootstrap.cc @ 750]
18 0aeaee94 106d49c8 chrome_fda0000!mojo::FilterChain::Accept+0x7f [C:\src\chromium\src\mojo\public\cpp\bindings\lib\filter_chain.cc @ 40]
19 0aeaefb4 106d4eac chrome_fda0000!mojo::Connector::ReadSingleMessage+0x156 [C:\src\chromium\src\mojo\public\cpp\bindings\lib\connector.cc @ 390]
1a 0aeaf0a0 106d4d96 chrome_fda0000!mojo::Connector::ReadAllAvailableMessages+0x4c [C:\src\chromium\src\mojo\public\cpp\bindings\lib\connector.cc @ 419]
1b 0aeaf16c 11fa8851 chrome_fda0000!mojo::Connector::OnHandleReadyInternal+0x84 [C:\src\chromium\src\mojo\public\cpp\bindings\lib\connector.cc @ 337]
1c 0aeaf178 107a3039 chrome_fda0000!base::internal::Invoker<base::internal::BindState<void (extensions::ExtensionMessagePort::*)(content::RenderFrameHost *) __attribute__((thiscall)), base::internal::UnretainedWrapper<extensions::ExtensionMessagePort> >, void (content::RenderFrameHost *)>::Run+0x11 [C:\src\chromium\src\base\bind_internal.h @ 343]
1d 0aeaf25c 1164237a chrome_fda0000!mojo::SimpleWatcher::OnHandleReady+0xeb [c:\src\chromium\src\mojo\public\cpp\system\simple_watcher.cc @ 261]
1e 0aeaf278 0fda6b97 chrome_fda0000!base::internal::Invoker<base::internal::BindState<void (viz::GLHelper::CopyTextureToImpl::*)(viz::GLHelper::CopyTextureToImpl::Request *, int) __attribute__((thiscall)), base::WeakPtr<viz::GLHelper::CopyTextureToImpl>, viz::GLHelper::CopyTextureToImpl::Request *, unsigned int>, void ()>::Run+0x34 [C:\src\chromium\src\base\bind_internal.h @ 343]
1f 0aeaf290 107876d4 chrome_fda0000!base::Callback<void (), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating>::Run+0x29 [C:\src\chromium\src\base\callback.h @ 91]
20 0aeaf390 10731319 chrome_fda0000!base::debug::TaskAnnotator::RunTask+0x1c4 [C:\src\chromium\src\base\debug\task_annotator.cc @ 61]
21 0aeaf4b0 107316c4 chrome_fda0000!base::MessageLoop::RunTask+0x2e9 [C:\src\chromium\src\base\message_loop\message_loop.cc @ 409]
22 0aeaf4c8 10731927 chrome_fda0000!base::MessageLoop::DeferOrRunPendingTask+0xa4 [C:\src\chromium\src\base\message_loop\message_loop.cc @ 420]
23 0aeaf57c 10789295 chrome_fda0000!base::MessageLoop::DoWork+0xf7 [C:\src\chromium\src\base\message_loop\message_loop.cc @ 508]
24 0aeaf590 1078866c chrome_fda0000!base::MessagePumpForIO::DoRunLoop+0x85 [C:\src\chromium\src\base\message_loop\message_pump_win.cc @ 476]
25 0aeaf5c4 10730e6a chrome_fda0000!base::MessagePumpWin::Run+0x6c [C:\src\chromium\src\base\message_loop\message_pump_win.cc @ 58]
26 0aeaf6a0 10758083 chrome_fda0000!base::MessageLoop::Run+0xea [C:\src\chromium\src\base\message_loop\message_loop.cc @ 360]
27 0aeaf7e8 1072ed02 chrome_fda0000!base::RunLoop::Run+0x83 [C:\src\chromium\src\base\run_loop.cc @ 112]
28 0aeaf8b4 100abc8a chrome_fda0000!base::Thread::Run+0xa2 [C:\src\chromium\src\base\threading\thread.cc @ 255]
29 0aeaf984 100abdce chrome_fda0000!content::BrowserThreadImpl::IOThreadRun+0x2a [C:\src\chromium\src\content\browser\browser_thread_impl.cc @ 279]
2a 0aeafa5c 1072f11f chrome_fda0000!content::BrowserThreadImpl::Run+0xe6 [C:\src\chromium\src\content\browser\browser_thread_impl.cc @ 313]
2b 0aeafb34 10704033 chrome_fda0000!base::Thread::ThreadMain+0x24f [C:\src\chromium\src\base\threading\thread.cc @ 338]
2c 0aeafb58 753b38f4 chrome_fda0000!base::`anonymous namespace'::ThreadFunc+0xa3 [C:\src\chromium\src\base\threading\platform_thread_win.cc @ 92]
2d 0aeafb6c 77c05de3 KERNEL32!BaseThreadInitThunk+0x24
2e 0aeafbb4 77c05dae ntdll!__RtlUserThreadStart+0x2f
2f 0aeafbc4 00000000 ntdll!_RtlUserThreadStart+0x1b

    std::unique_ptr<storage::BlobDataHandle> handle =
        blob_context->GetBlobDataFromUUID(element.blob_uuid());
    DCHECK(handle); <--- HERE
    if (!handle)
      continue;

 

Comment 1 by wfh@chromium.org, May 26 2017

Cc: ananta@chromium.org scottmg@chromium.org
Components: Blink>Loader
I'm not sure what that is, this is all in the old non-network service path though (as it's using ResourceDispatcherHostImpl)

Comment 3 by kouhei@chromium.org, May 30 2017

Cc: tzik@chromium.org yhirano@chromium.org
Owner: kinuko@chromium.org
Status: Available (was: Untriaged)
kinuko: Would you help triage this?

Comment 4 by kinuko@chromium.org, May 30 2017

Cc: dmu...@chromium.org
Components: -Internals Blink>Storage
Owner: dmu...@chromium.org
Something has tried to upload a file/blob but the blob was already gone when the request reached the browser process.  I think in regular cases we keep the blob data handle around in the request?

dmurph@: do you think you can take a look?

Comment 5 by dmu...@chromium.org, May 31 2017

Mergedinto: 692860
Status: Duplicate (was: Available)
Duplicate of this:
https://bugs.chromium.org/p/chromium/issues/detail?id=692860

I have a patch, but I'm having trouble figuring out how to test it:
https://codereview.chromium.org/2829923004


Sign in to add a comment