Issue metadata
Sign in to add a comment
|
Regression : 'Wi-Fi is turned off/on' Text is seen weird on Disabling or Enabling 'Wi-Fi' in Network of Uber Tray |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3110.0/9590.0.0 Dev-channel Daisy,Candy and Peppy OS: Chrome What steps will reproduce the problem? (1)Recover build -> In OOBE scree navigate to 'Connect to Network' screen (2)Now Click on Uber Tray -> Select 'Network' option -> Disable 'Wi-Fi' and observe 'Wi-Fi is turned off' Text (please refer Video and Screenshot) Note : Enable 'Wi-Fi' and observe 'Wi-Fi is turned on' Text is seen weird Expected: 'Wi-Fi is turned off/on' Text is seen weird on Disabling or Enabling 'Wi-Fi' in Network of Uber Tray Actual: Instead 'Wi-Fi is turned off/on' Text is seen weird This is Regression Issue as same is working fine in 60.0.3107.0/9582.0.0 dev-channel Candy @tbuckley: Please confirm the Issue.
,
May 26 2017
Issue is also seen in Notifications Steps: Click on Notifications -> click on 'Settings' icon and now observe text (Please refer Attachment)
,
May 26 2017
Oh wow, that's not good. This seems like a general font rendering issue, not something specific to the status area. @tdanderson do you know who could look into this? +abodenha as well
,
May 26 2017
I can't reproduce locally and don't have any of the devices mentioned in #0. Looking through some recent changes, here are some candidates that jump out as possibilities (none I'm confident in, though). Evan, any ideas here? * Simplifications of GetPreferredSize overrides (https://chromium-review.googlesource.com/c/513505/) * Remove extra padding from system menu labels (https://chromium-review.googlesource.com/c/508391/) * Make a layer for popup MessageView (https://codereview.chromium.org/2880243003) * Use views::style for buttons, bootstrap ash_typography to do so (https://codereview.chromium.org/2801583002)
,
May 26 2017
definitely looks like a subpixel aa on transparent layer bug. A bisect would be nice.
,
May 30 2017
Albert, would there be anyone on your team (who can repro this on device) be able to look into this?
,
May 30 2017
,
May 30 2017
Currently do not have access to any of the cros devices listed and am unable to repro this locally. It definitely looks like an issue with Subpixel Rendering. Deferring to +afakhry
,
May 30 2017
zelidrag@ ran into it on chell.
,
May 30 2017
Bisecting is in progress ...
,
May 30 2017
Culprit CL is https://codereview.chromium.org/2895003002. Assigning to owner.
,
May 30 2017
This stems from attempting to fix 665412. Generically if you are using a ScrollView and some descendant of the View has a Layer, than the ScrollView (actually the viewport) needs a layer too. To do otherwise leads to drawing outside the bounds of the scrollview: see https://storage.googleapis.com/monorail-prod.appspot.com/16/attachments/d9f83f03-9331-4f4d-bb44-bb9a10138993?Expires=1496185213&GoogleAccessId=monorail-prod%40appspot.gserviceaccount.com&Signature=dQww%2FJ8qMV1wSfiqFf1uVI0MCsDSACLgwxym3bNO7rUQVdnI8AQ5Lyi7Uz47Hm7WzovVJDAVmKRu5t61DsbWoURh3%2FnF3llBuKJEN%2BAYqRsj24XV1RxMdn%2Bwbmig0DvhzuOzbm%2FLmRXTj6cOuP8LyNqJ4be2c3ORppGCMQ9MBlxcHYfVeUfiP28fRleus87RVZFp2r7kFzb4WlcgBerEbS6RdYEiwZnw1m%2Bf9hXcb%2FzO8nJ9EJ9xCM846JnwagzqFkJAb1NvweFSZ4HXQB0C6yAvi1bk5hEP3LvfrZfpufD74d5C9S%2Bq4uldBF8LZ1OtnI2oisDa9ywtgPnze6es2A%3D%3D for an example. So, the ScrollView in this settings must have a child view that has a layer, forcing the viewport to have a layer. I think the right fix is to explicitly turn on a layer for the viewport, set a background color and call SetFillsBoundsOpaquely(true). I don't know what background color should be used. James or Sadrul, would you happen to know what color to use? James, I'm assigning to you, as I suspect you know best what color to use or at least how to lookup the color. James, feel free to kick back to Ananta or myself.
,
May 30 2017
I think the color comes from the native theme, ui::NativeTheme::kColorId_DialogBackground - see https://cs.chromium.org/chromium/src/ui/views/bubble/bubble_frame_view.cc?sq=package:chromium&l=360 Tray background color comes from views::TrayBubbleView::InitParams::bg_color. https://cs.chromium.org/chromium/src/ui/views/bubble/tray_bubble_view.h?sq=package:chromium&l=86 If that's not correct, then it might be ash::kHeaderBackgroundColor: https://cs.chromium.org/chromium/src/ash/system/tray/tray_constants.cc?sq=package:chromium&l=67 from https://cs.chromium.org/chromium/src/ash/system/tray/system_tray.cc?sq=package:chromium&l=469 But I'm pretty sure this is a "detailed view", so it should be the former color.
,
May 31 2017
,
May 31 2017
,
Jun 1 2017
Issue 727946 has been merged into this issue.
,
Jun 2 2017
Issue 728766 has been merged into this issue.
,
Jun 2 2017
Seems to be gone on Peppy with the most recent Dev update.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f985b8525943238bd43ce4e717f06613b26d284b commit f985b8525943238bd43ce4e717f06613b26d284b Author: Scott Violet <sky@chromium.org> Date: Fri Jun 02 21:37:25 2017 views: makes ScrollView have a background This change does a couple of things to scrollview: It makes it explicitly have a background. The background can be set by either a specific color (including transparent) or a theme color id. The default is a theme color id, which is the more prevalent use If ScrollView turns on a layer (because a descendant has a layer), then fills-bounds-opaquely is updated by on the background color. This also removes explicit calls to EnableViewportLayer() as ScrollView should automatically enable a layer as necessary. BUG= 726595 TEST=covered by test R=ananta@chromium.org Change-Id: Ideaf8307fec6b8ad452588912dd19394136256e5 Reviewed-on: https://chromium-review.googlesource.com/519464 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org> Reviewed-by: Ananta Iyengar <ananta@chromium.org> Cr-Commit-Position: refs/heads/master@{#476801} [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/ash/system/tray/tray_details_view.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/chrome/browser/ui/views/extensions/extension_install_dialog_view.h [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/chrome/browser/ui/views/intent_picker_bubble_view.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/ui/views/controls/scroll_view.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/ui/views/controls/scroll_view.h [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/ui/views/controls/scroll_view_unittest.cc [modify] https://crrev.com/f985b8525943238bd43ce4e717f06613b26d284b/ui/views/view_unittest.cc
,
Jun 5 2017
I had the chance to try Chrome 61.0.3119 and the issue seems to be fixed thanks to sky@ CL, we need this merged to M60 right?
,
Jun 5 2017
Yes. I was going to let it bake for a little while longer before requesting merge.
,
Jun 6 2017
I'm requesting a merge of https://chromium-review.googlesource.com/519464 of 60. It landed a few days back and I haven't seen any problems because of it.
,
Jun 6 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0e01dcb419ed9bc926bfd8dce035fae047551a0 commit d0e01dcb419ed9bc926bfd8dce035fae047551a0 Author: Scott Violet <sky@chromium.org> Date: Tue Jun 06 21:11:31 2017 [MERGE] views: makes ScrollView have a background This is a merge to branch 3112 This change does a couple of things to scrollview: It makes it explicitly have a background. The background can be set by either a specific color (including transparent) or a theme color id. The default is a theme color id, which is the more prevalent use If ScrollView turns on a layer (because a descendant has a layer), then fills-bounds-opaquely is updated by on the background color. This also removes explicit calls to EnableViewportLayer() as ScrollView should automatically enable a layer as necessary. BUG= 726595 TEST=covered by test R=ananta@chromium.org TBR=sky@chromium.org Change-Id: I484b512845d8d0d6bc6516c68adc91b7a28e5fa8 Reviewed-on: https://chromium-review.googlesource.com/526335 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#206} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/ash/system/tray/tray_details_view.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/chrome/browser/ui/views/extensions/extension_install_dialog_view.h [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/chrome/browser/ui/views/intent_picker_bubble_view.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/ui/views/controls/scroll_view.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/ui/views/controls/scroll_view.h [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/ui/views/controls/scroll_view_unittest.cc [modify] https://crrev.com/d0e01dcb419ed9bc926bfd8dce035fae047551a0/ui/views/view_unittest.cc
,
Jun 6 2017
,
Jun 9 2017
Issue 729472 has been merged into this issue.
,
Jun 9 2017
,
Jun 15 2017
,
Jul 5 2017
Issue 736707 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, May 26 2017164 KB
164 KB View Download