New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726588 link

Starred by 2 users
Status: Started
Owner:
yawano@chromium.org
Cc:
█ yoshiki@chromium.org
osh...@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 788087


Sign in to add a comment

Opening notification tray pauses Android application

Project Member Reported by yawano@chromium.org, May 26 2017 
Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Open notification tray.
(2) Android application pauses. Activity.onPause is called in Android application.

What is the expected result?
Android application doesn't pause.

What happens instead?
Android application pauses.

For system tray (a tray which has sign out button), we already fixed this. We need to put same fix for other trays as well.

Comment 1 by yawano@chromium.org, May 30 2017

Cc: yoshiki@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c

commit c97f341f1a2f6f359ba1a7c8687aa58af6f7033c
Author: yawano <yawano@chromium.org>
Date: Thu Jun 22 03:07:12 2017

Do not activate TrayBubbleView by default

- Activating a TrayBubbleView brings an Android window to onPause state.
- This CL sets can_set_activate to false and makes TrayBubbleView not
  activated by default.
- If the TrayBubbleView is not activated, it cannot capture key events
  for moving focus or closing the view by keyboard. TrayBubbleView tries
  to register accelerators at the global level to capture those key
  events.
- Activates the TrayBubbleView by default if keyboard navigation
  accessibility feature (e.g. spoken feedback) is enabled.

BUG=726588,731748
TEST=Follow steps described in the issue

Review-Url: https://codereview.chromium.org/2897553002
Cr-Commit-Position: refs/heads/master@{#481421}

[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/palette/palette_tray.h
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/tray/system_tray.cc
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/tray/system_tray.h
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/tray/system_tray_bubble.h
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ui/message_center/views/message_bubble_base.cc
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c/ui/views/bubble/tray_bubble_view.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cafb5aa2544670f4313e102e3ff12225dc5dafa

commit 0cafb5aa2544670f4313e102e3ff12225dc5dafa
Author: vabr <vabr@chromium.org>
Date: Thu Jun 22 09:03:27 2017

Revert of Do not activate TrayBubbleView by default (patchset #15 id:270001 of https://codereview.chromium.org/2897553002/ )

Reason for revert:
Speculative revert. I suspect this broke the interactive_ui_tests on Linux ChromiumOS MSan Tests (https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/1276). The tests now time out, and the log contains lines with:

Still waiting for the following processes to finish:
	./interactive_ui_tests --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0 --single_process --test-launcher-bot-mode --test-launcher-print-test-stdio=always --test-launcher-summary-output=/b/s/w/ioS9oZeu/output.json --user-data-dir=/b/s/w/it1bN0Em/.org.chromium.Chromium.iOqw8e/dOj481Q

Original issue's description:
> Do not activate TrayBubbleView by default
>
> - Activating a TrayBubbleView brings an Android window to onPause state.
> - This CL sets can_set_activate to false and makes TrayBubbleView not
>   activated by default.
> - If the TrayBubbleView is not activated, it cannot capture key events
>   for moving focus or closing the view by keyboard. TrayBubbleView tries
>   to register accelerators at the global level to capture those key
>   events.
> - Activates the TrayBubbleView by default if keyboard navigation
>   accessibility feature (e.g. spoken feedback) is enabled.
>
> BUG=726588,731748
> TEST=Follow steps described in the issue
>
> Review-Url: https://codereview.chromium.org/2897553002
> Cr-Commit-Position: refs/heads/master@{#481421}
> Committed: https://chromium.googlesource.com/chromium/src/+/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c

TBR=stevenjb@chromium.org,dmazzoni@chromium.org,msw@chromium.org,jamescook@chromium.org,yawano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=726588,731748

Review-Url: https://codereview.chromium.org/2948223002
Cr-Commit-Position: refs/heads/master@{#481485}

[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/palette/palette_tray.h
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/tray/system_tray.cc
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/tray/system_tray.h
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/tray/system_tray_bubble.h
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ui/message_center/views/message_bubble_base.cc
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/0cafb5aa2544670f4313e102e3ff12225dc5dafa/ui/views/bubble/tray_bubble_view.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c305b497c7f8e2125a05f544fd346862f0bb8e

commit 66c305b497c7f8e2125a05f544fd346862f0bb8e
Author: yawano <yawano@chromium.org>
Date: Tue Jun 27 00:37:14 2017

Reland with a fix: Do not activate TrayBubbleView by default

- Activating a TrayBubbleView brings an Android window to onPause state.
- This CL sets can_set_activate to false and makes TrayBubbleView not
  activated by default.
- If the TrayBubbleView is not activated, it cannot capture key events
  for moving focus or closing the view by keyboard. TrayBubbleView tries
  to register accelerators at the global level to capture those key
  events.
- Activates the TrayBubbleView by default if keyboard navigation
  accessibility feature (e.g. spoken feedback) is enabled.

TBR=dmazzoni@chromium.org, jamescook@chromium.org
BUG=726588,731748
TEST=Follow steps described in the issue

Review-Url: https://codereview.chromium.org/2897553002
Cr-Commit-Position: refs/heads/master@{#481421}
Committed: https://chromium.googlesource.com/chromium/src/+/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c

patch from issue 2897553002 at patchset 270001 (http://crrev.com/2897553002#ps270001)

Review-Url: https://codereview.chromium.org/2958693002
Cr-Commit-Position: refs/heads/master@{#482490}

[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/palette/palette_tray.h
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/tray/system_tray.cc
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/tray/system_tray.h
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/tray/system_tray_bubble.h
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ui/message_center/views/message_bubble_base.cc
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/66c305b497c7f8e2125a05f544fd346862f0bb8e/ui/views/bubble/tray_bubble_view.h

Comment 5 by yoshiki@chromium.org, Apr 3 2018

Blockedon: 788087
Components: -UI>Shell UI>Shell>Notifications Platform>ARC

Comment 6 by yoshiki@chromium.org, Apr 3 2018 

I believe this is fixed except  Issue 788087 ?
►

Sign in to add a comment