Incorrect position of list marker below a float
Reported by
kwk...@vivliostyle.com,
May 26 2017
|
|||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:55.0) Gecko/20100101 Firefox/55.0
Steps to reproduce the problem:
1. Open the attached test case
What is the expected behavior?
The list marker should be on the left side of the list content ("list")
What went wrong?
The list marker is far right to the list content.
Did this work before? No
Does this work in other browsers? Yes
Chrome version: 58.0.3029.110 (Official Build) (64bit) Channel: stable
OS Version: OS X 10.12
Flash Version: Shockwave Flash 24.0 r0
,
May 26 2017
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc0213148ed03241f5480b039bba5d2b8ae3e831 commit fc0213148ed03241f5480b039bba5d2b8ae3e831 Author: Robert Hogan <robhogan@gmail.com> Date: Tue May 30 17:13:30 2017 List markers should only avoid floats on their own line. Bug: 726583 Change-Id: I4bec94e9034b00b4328f5c2c33c2fa95d0d83698 Reviewed-on: https://chromium-review.googlesource.com/517822 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#475574} [add] https://crrev.com/fc0213148ed03241f5480b039bba5d2b8ae3e831/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-expected.html [add] https://crrev.com/fc0213148ed03241f5480b039bba5d2b8ae3e831/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float.html [modify] https://crrev.com/fc0213148ed03241f5480b039bba5d2b8ae3e831/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp
,
Jun 2 2017
Thank you for working on this! Has this issue been finished by the patch? Do you happen to have time estimate for when the fix is shipped in which channel?
,
Jun 2 2017
,
Jun 2 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e77ecceef64cb7e406b02d37953eccb3a6715fbb commit e77ecceef64cb7e406b02d37953eccb3a6715fbb Author: Robert Hogan <robhogan@gmail.com> Date: Fri Jun 02 09:20:50 2017 List markers should only avoid floats on their own line. TBR=robhogan@gmail.com (cherry picked from commit fc0213148ed03241f5480b039bba5d2b8ae3e831) Bug: 726583 Change-Id: I4bec94e9034b00b4328f5c2c33c2fa95d0d83698 Reviewed-on: https://chromium-review.googlesource.com/517822 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#475574} Reviewed-on: https://chromium-review.googlesource.com/522683 Reviewed-by: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/branch-heads/3112@{#110} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [add] https://crrev.com/e77ecceef64cb7e406b02d37953eccb3a6715fbb/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-expected.html [add] https://crrev.com/e77ecceef64cb7e406b02d37953eccb3a6715fbb/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float.html [modify] https://crrev.com/e77ecceef64cb7e406b02d37953eccb3a6715fbb/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp
,
Jun 6 2017
Verified this issue on Ubuntu 14.04, Windows-10 and Mac OS 10.12 using chrome latest dev M60-60.0.3112.20 by following steps mentioned in the original comment. Observed the list marker is seen on left side of the list content as expected. Hence adding TE-Verified label.
,
Jul 30 2017
,
Aug 1 2017
Though the original testcase has been fixed, it seems that a slightly modified testcase still exhibits the same problem. I attached a new testcase where I simply removed 'clear: left' on the ul element.
,
Aug 2 2017
I still see the problem on Chrome 60.0.3112.78 and 62.0.3173.0, both on macOS 10.12.6. A weird point is that the problem exists just after loading the HTML file, it disappears when the window size is changed.
,
Aug 2 2017
OK, I can reproduce your results when I put the test on https://jsfiddle.net/u2a1x1Lx/ and throttle the network connection. Can you reproduce it even when the test is a local html file?
,
Aug 10 2017
As you can see from my screencast, I reproduced it with a local HTML file. I tried Chrome 60.0.3112.90 on CentOS 7 and it did not reproduce, which agrees with your screencast.
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd7e6cfdc27d56c2a1ed52bd802aad7b5e11e8d5 commit cd7e6cfdc27d56c2a1ed52bd802aad7b5e11e8d5 Author: Robert Hogan <robhogan@gmail.com> Date: Mon Aug 14 23:21:22 2017 List markers should only avoid floats on their own line. We used to update the offset of list markers after we had laid out the line but this resulted in the list marker avoiding floats that came after it in layout (https://codereview.chromium.org/2553793003). PositionListMarker() always happens after a layout of the list item so it's reasonable to always update the offset when laying one out. We can do better than this though and only update the offset when we know there's a float to avoid, so do that instead. The layout of a list marker consists simply of finding its offset and updating its margins so it's cheap enough to treat a layout as an update to the offset. Bug: 726583 , 753099 Change-Id: I5aca82ae654f1ddece448fc89563f90b801d1110 Reviewed-on: https://chromium-review.googlesource.com/602352 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#494238} [add] https://crrev.com/cd7e6cfdc27d56c2a1ed52bd802aad7b5e11e8d5/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-2-expected.html [add] https://crrev.com/cd7e6cfdc27d56c2a1ed52bd802aad7b5e11e8d5/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-2.html [add] https://crrev.com/cd7e6cfdc27d56c2a1ed52bd802aad7b5e11e8d5/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-3-expected.html [add] https://crrev.com/cd7e6cfdc27d56c2a1ed52bd802aad7b5e11e8d5/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-3.html [modify] https://crrev.com/cd7e6cfdc27d56c2a1ed52bd802aad7b5e11e8d5/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
,
Oct 24 2017
Has this fix landed? I still see the same problem shown in my screencasts in comment #12 on Chrome 62.0.3202.62 and 64.0.3248.0 on macOS 10.12.6.
,
Nov 14 2017
Is there any update on this? I still see the same problem on Chrome 62.0.3202.94 and 64.0.3265.0 on macOS 10.12.6.
,
Nov 14 2017
#17 - it was merged to Chrome 60, so you might be looking at a new issue. Please, look for a non-fixed issue and if you cannot find one, file a new issue and attach a small reproduction (a small HTML file that reproduces the issue). You can comment here with the issue number.
,
Nov 14 2017
Thank you for your response. The issue I am seeing is the same as I reported on comments #10, #12 and I do not have any additional information, but I can file a new issue for that if it helps.
,
Nov 14 2017
#19 - I think it would be best to make sure there is an open (non-fixed) issue for that, or create one, yes.
,
Nov 14 2017
I tried to find a non-fixed issue with "list marker" keywords but could not find one, so filed a new issue: https://bugs.chromium.org/p/chromium/issues/detail?id=784793 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nyerramilli@chromium.org
, May 26 2017Labels: Needs-Miilestone OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
576 KB
576 KB View Download