New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726579 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Long OOO (go/where-is-mgiuca)
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Memory leak in CrOSComponentInstallerTest.BPPPCompatibleCrOSComponent (failing on chromium.memory/Linux Chromium OS ASan LSan)

Project Member Reported by mgiuca@chromium.org, May 26 2017

Issue description

unit_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

This was initially linked to  Issue 725305  but I suspect it's different because that was reverted yesterday.

FindIt blamed r474798. Investigating.
 
fix is pending review: https://codereview.chromium.org/2902373003/

Comment 2 by mgiuca@chromium.org, May 26 2017

Summary: Memory leak in CrOSComponentInstallerTest.BPPPCompatibleCrOSComponent (failing on chromium.memory/Linux Chromium OS ASan LSan) (was: unit_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1))
Project Member

Comment 3 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44c957b81b919e80612133fc5e9d4847252b1258

commit 44c957b81b919e80612133fc5e9d4847252b1258
Author: xiaochu <xiaochu@chromium.org>
Date: Fri May 26 04:53:44 2017

Fix memory leak CrOSComponentInstallerTest.BPPPCompatibleCrOSComponent unittest

Replace raw pointer with a stack variable.

BUG=chromium:690521,  chromium:726579 
TEST=passed trybots.

Review-Url: https://codereview.chromium.org/2902373003
Cr-Commit-Position: refs/heads/master@{#474911}

[modify] https://crrev.com/44c957b81b919e80612133fc5e9d4847252b1258/chrome/browser/component_updater/cros_component_installer_unittest.cc

Comment 4 by mgiuca@chromium.org, May 26 2017

Status: Fixed (was: Available)

Comment 5 by guidou@chromium.org, May 26 2017

Labels: -Sheriff-Chromium

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment