New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726577 link

Starred by 1 user
Status: Duplicate
Merged: issue 722887
Owner:
qyears...@chromium.org
Closed: May 2017
Cc:
█ mgiuca@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 726571



Sign in to add a comment

wpt-import: Doesn't set Mac 10.9 when auto disabling tests

Project Member Reported by mgiuca@chromium.org, May 26 2017 
See  Issue 726571 . wpt-import automatically disabled 9 new tests here:
https://chromium-review.googlesource.com/c/515422/3/third_party/WebKit/LayoutTests/TestExpectations

crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/2dcontext/building-paths/canvas_complexshapes_arcto_001.htm [ Failure ]
crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/2dcontext/building-paths/canvas_complexshapes_beziercurveto_001.htm [ Failure ]
crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_11.html [ Failure ]
crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_12.html [ Failure ]
crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_12.html [ Failure ]
crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_13.html [ Failure ]
crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/2dcontext/drawing-paths-to-the-canvas/canvas_focus_drawFocusIfNeeded_AAPI_001-manual.html [ Skip ]
crbug.com/626703 [ Android Mac10.10 Mac10.11 Mac10.12 Retina ] external/wpt/2dcontext/the-canvas-state/canvas_state_restore_001.htm [ Failure ]
crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/html/semantics/embedded-content/the-img-element/ismap/img-ismap-coordinates-manual.html [ Skip ]

For some reason it blanket disables on Android, Linux and Win, but is very specific about Mac versions, explicitly disabling on Mac10.10, Mac10.11 and Mac10.12.

Unfortunately, these 9 tests fail on all Mac versions. For some reason wpt-import doesn't set Mac10.9. It should either:

1. Test and disable if necessary on "Mac10.9", or
2. Just blanket disable "Mac" as a whole.

Comment 1 by qyears...@chromium.org, May 26 2017

Blockedon: -726571
Blocking: 726571
Mergedinto: 722887
Status: Duplicate (was: Assigned)
The reason why this happened in this particular case is that in the initial set of try jobs, just the Mac10.9 didn't have any results; it had a failure in the compile step:
https://build.chromium.org/p/tryserver.blink/builders/mac10.9_blink_rel/builds/2710

In this particular case, the expectations would have been correct if Mac10.9 was automatically added to the list of platforms, and then it would have been simplified away; these expectations should not have been platform-specific.
►

Sign in to add a comment