Issue metadata
Sign in to add a comment
|
9 canvas tests (webkit_tests) failing on chromium.webkit/WebKit Mac10.9 |
||||||||||||||||||||||
Issue descriptionwebkit_tests failing on chromium.webkit/WebKit Mac10.9 Builders failed on: - WebKit Mac10.9: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9 Test results on the first failure: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9/46604/layout-test-results/results.html r474764 added all of these as new tests (automated import): """ If this CL causes a small number of new layout test failures, it may be easier to add lines to TestExpectations rather than reverting. """ Umm... 1. that probably won't be easier (for me anyhow!), and 2. sigh, so we are just supposed to throw these 18 tests on the ever-growing pile of TestExpectations?
,
May 26 2017
The failures are: * external/wpt/2dcontext/building-paths/canvas_complexshapes_arcto_001.htm * external/wpt/2dcontext/building-paths/canvas_complexshapes_beziercurveto_001.htm * external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_11.html * external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_12.html * external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_12.html * external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_13.html * external/wpt/2dcontext/drawing-paths-to-the-canvas/canvas_focus_drawFocusIfNeeded_AAPI_001-manual.html * external/wpt/2dcontext/the-canvas-state/canvas_state_restore_001.htm * external/wpt/html/semantics/embedded-content/the-img-element/ismap/img-ismap-coordinates-manual.html Now I'm getting really confused. It seems that the very same import CL automatically added exactly these 9 tests to the TestExpectations file: https://chromium-review.googlesource.com/c/515422/3/third_party/WebKit/LayoutTests/TestExpectations Oh, I see... it added all the individual operating systems except Mac10.9. That explains why this is only failing on Mac 10.9 despite it seemingly being a missing drawing feature.
,
May 26 2017
,
May 26 2017
The fix is coming but it's taking awhile: https://chromium-review.googlesource.com/c/516863/
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/560d24759e7e4cecba4d81d1479e13d6f81314d4 commit 560d24759e7e4cecba4d81d1479e13d6f81314d4 Author: Matt Giuca <mgiuca@chromium.org> Date: Fri May 26 05:01:53 2017 Fixed TestExpectations for 9 recently added Web Platform tests. These had been automatically disabled on Mac 10.10, 10.11 and 10.12. But they are failing on ALL platforms, including Mac 10.9 which wasn't explicitly mentioned. Updated to just mention "Mac" without specific versions. TBR=mgiuca@chromium.org Bug: 726571 Change-Id: Ia1c33e13181a5b75f9e20f81f203c2d473c67811 Reviewed-on: https://chromium-review.googlesource.com/516863 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#474913} [modify] https://crrev.com/560d24759e7e4cecba4d81d1479e13d6f81314d4/third_party/WebKit/LayoutTests/TestExpectations
,
May 26 2017
Marking Fixed to get out of my queue. I will keep an eye on it to make sure the expectation passes on the next run.
,
May 26 2017
Seems to be passing on all the Mac builders now \o/.
,
May 26 2017
,
May 26 2017
,
May 26 2017
By the way mgiuca@, thanks for fixing this, and sorry for all of the trouble!
,
May 30 2017
np, thanks for having automation on this and quick response. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mgiuca@chromium.org
, May 26 2017