WrapperVisitor needs to support HeapHashMap<T, TraceWrapperMember<U>> |
||
Issue descriptionI'm trying to add HeapHashMap<uint32_t, TraceWrapperMember<T>> but get following error message when I add visitor->TraceWrappers(hashmap). ../../third_party/WebKit/Source/modules/nfc/NFC.cpp:915:12: error: no matching member function for call to 'TraceWrappers' visitor->TraceWrappers(callbacks_); It seems that WrapperVisitor doesn't support HeapHashMap.
,
May 26 2017
You have to manually trace the values. See e.g. [1] When we started with wrapper tracing, we decided we would not add explicit support for Heap* containers to avoid code complexity. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h?type=cs&q=TraceWrapperMember&sq=package:chromium&l=144
,
May 26 2017
I see. Thank you for the clarification!
,
May 26 2017
Forgot to add: If you feel that the use is widespread and we should support this now (same w/ HeapVector), then we can certainly think of a way. It just was not a priority so far.
,
May 26 2017
I've started replacing wrongly used "callback interface" with "callback function" (list: https://docs.google.com/spreadsheets/d/1CbyEoTYJyeVCz6crJiHU7kHkSo0ghhIqUqDyZnRrTvE/edit#gid=0) and noticed that we would need some Heap* containers to keep references (at least for MessageCallback and AudioBufferCallback). Having container support would be great but no pressure :) |
||
►
Sign in to add a comment |
||
Comment 1 by bashi@chromium.org
, May 26 2017Status: Assigned (was: Available)