On device and/or account setup, Cryptauth device sync happens before Cryptauth enrollment |
||||
Issue descriptionThis issue manifests as being correctly enrolled with CryptAuth and having other RemoteDevices available via CryptAuthDeviceManager, but not having the local device be present in the list returned by CryptAuthDeviceManager::GetSyncedDevices(). One consequence of this: the local device can't fetch its own beacon seeds :( It seems that device sync either happens before enrollment, or the two are racing. If I check chrome://proximity-auth, I see: Enrollment: last success: 5/25/2017 5:01:24 PM. Device sync: last success: 5/25/2017 5:01:23 PM. As you can see, device sync occurred 1 second *before* enrollment, so there's no way for the devices pulled down to include the local device. Proposed solution: Tweak ChromeCryptAuthService to only call CryptAuthDeviceManager::Start() at first, and then call CryptAuthEnrollmentManager::Start() when CryptAuthDeviceManager::OnEnrollmentFinished() is called. Tim, can you weigh in on if this is a decent solution?
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdcf8951a275f7f572ea15bdfe921ed222598159 commit bdcf8951a275f7f572ea15bdfe921ed222598159 Author: hansberry <hansberry@chromium.org> Date: Thu Jun 01 21:23:50 2017 ChromeCryptAuthService: only perform device sync once enrollment is complete. BUG= 726553 Review-Url: https://codereview.chromium.org/2911583003 Cr-Commit-Position: refs/heads/master@{#476440} [modify] https://crrev.com/bdcf8951a275f7f572ea15bdfe921ed222598159/chrome/browser/cryptauth/chrome_cryptauth_service.cc [modify] https://crrev.com/bdcf8951a275f7f572ea15bdfe921ed222598159/chrome/browser/cryptauth/chrome_cryptauth_service.h
,
Jun 1 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tengs@chromium.org
, May 31 2017