New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726551 link

Starred by 2 users
Status: Fixed
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ tilmansp@google.com
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Remove 'Manage Cast Devices' option from cast icon in incognito windows

Project Member Reported by imch...@chromium.org, May 26 2017 
Per skonig@ in internal bug:

Cast setup is inoperative in an Incognito profile (which is correct); however the option is still presented in Incognito. We should simply disable the Manage Cast Devices option in the context menu if the profile is Incognito.
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f97c95ec5e806e2fe5dc2a6c33ec8d1c5aba2e4

commit 0f97c95ec5e806e2fe5dc2a6c33ec8d1c5aba2e4
Author: imcheng <imcheng@chromium.org>
Date: Fri May 26 22:46:52 2017

[Media Router] Don't show "Manage Cast Devices" in incognito mode.

The cast setup page does not work in incognito mode anyway.

BUG= 726551 

Review-Url: https://codereview.chromium.org/2908463003
Cr-Commit-Position: refs/heads/master@{#475168}

[modify] https://crrev.com/0f97c95ec5e806e2fe5dc2a6c33ec8d1c5aba2e4/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/0f97c95ec5e806e2fe5dc2a6c33ec8d1c5aba2e4/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc

Comment 2 by imch...@chromium.org, May 26 2017

Status: Fixed (was: Untriaged)

Comment 3 by mfo...@chromium.org, Jul 21 2017

Cc: tilmansp@google.com
 Issue 650262  has been merged into this issue.
►

Sign in to add a comment