New issue
Advanced search Search tips

Issue 726536 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jun 2017
Cc:
thestig@chromium.org
dbeam@chromium.org
rbpotter@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Print preview: Modernize tests to use Mocha

Project Member Reported by dpa...@chromium.org, May 25 2017 
https://cs.chromium.org/chromium/src/chrome/test/data/webui/print_preview/print_preview.js

There are multiple advantages of using Mocha for our JS tests.

- Better async test support (via Promises)
- Convenient test lifecycle via suite() -> suiteSetup() -> setup() -> test() -> teadown() -> suiteTeardown().
- Isolate JS test code from JS to C++ conversion code (old js2gtest mechanism)
- No need to recompile browser_tests while iterating on a test.
- Consistent with newer WebUI tests (MD Settings + other MD pages).
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa46590a75919b4892df4d26074cf074bd79b048

commit fa46590a75919b4892df4d26074cf074bd79b048
Author: dpapad <dpapad@chromium.org>
Date: Fri May 26 20:49:55 2017

Print Preview: Migrate some JS tests to use Mocha.

Migrated following tests (and also shortened names to be less verbose)

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules -> DefaultDestinationSelectionRules

Migrated tests 5, remaining tests 31.

BUG= 726536 

Review-Url: https://codereview.chromium.org/2887003002
Cr-Commit-Position: refs/heads/master@{#475118}

[modify] https://crrev.com/fa46590a75919b4892df4d26074cf074bd79b048/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/fa46590a75919b4892df4d26074cf074bd79b048/chrome/test/data/webui/print_preview/print_preview.js
[add] https://crrev.com/fa46590a75919b4892df4d26074cf074bd79b048/chrome/test/data/webui/print_preview/print_preview_tests.js
[add] https://crrev.com/fa46590a75919b4892df4d26074cf074bd79b048/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
Project Member

Comment 2 by bugdroid1@chromium.org, May 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a225601e7fcf2c57ea5376edf1e55e722216343

commit 4a225601e7fcf2c57ea5376edf1e55e722216343
Author: dpapad <dpapad@chromium.org>
Date: Sat May 27 02:01:18 2017

Print Preview: Migrate JS tests to use Mocha, part 2.

Migrating following tests:

  SystemDialogLinkIsHiddenInAppKioskMode
  SectionsDisabled
  PrintToPDFSelectedCapabilities
  SourceIsHTMLCapabilities
  SourceIsPDFCapabilities
  ScalingUnchecksFitToPage
  CheckNumCopiesPrintPreset
  CheckDuplexPrintPreset
  CustomMarginsControlsCheck
  PageLayoutHasNoMarginsHideHeaderFooter
  PageLayoutHasMarginsShowHeaderFooter

Migrated tests 16, remaining tests 20.

BUG= 726536 

Review-Url: https://codereview.chromium.org/2910503003
Cr-Commit-Position: refs/heads/master@{#475217}

[modify] https://crrev.com/4a225601e7fcf2c57ea5376edf1e55e722216343/chrome/test/data/webui/print_preview/print_preview.js
[modify] https://crrev.com/4a225601e7fcf2c57ea5376edf1e55e722216343/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/4a225601e7fcf2c57ea5376edf1e55e722216343/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf195c35d5f9cd9c90b8688e1d9c50c4cfd5522e

commit cf195c35d5f9cd9c90b8688e1d9c50c4cfd5522e
Author: dpapad <dpapad@chromium.org>
Date: Wed May 31 22:05:10 2017

Print Preview: Migrate JS tests to use Mocha, part 3.

Migrating the following tests:

ZeroTopAndBottomMarginsHideHeaderFooter
ZeroTopAndNonZeroBottomMarginShowHeaderFooter
SmallPaperSizeHeaderFooter
TestColorSettingsMonochrome
TestColorSettingsCustomMonochrome
TestColorSettingsColor
TestColorSettingsCustomColor
TestColorSettingsBothStandardDefaultColor
TestColorSettingsBothStandardDefaultMonochrome
TestColorSettingsBothCustomDefaultColor

Migrated tests 26, remaining tests 10.

BUG= 726536 

Review-Url: https://codereview.chromium.org/2911203003
Cr-Commit-Position: refs/heads/master@{#476054}

[modify] https://crrev.com/cf195c35d5f9cd9c90b8688e1d9c50c4cfd5522e/chrome/test/data/webui/print_preview/print_preview.js
[modify] https://crrev.com/cf195c35d5f9cd9c90b8688e1d9c50c4cfd5522e/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/cf195c35d5f9cd9c90b8688e1d9c50c4cfd5522e/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87c1fd7ea6e69c1d208a92301423b2bc7584bc97

commit 87c1fd7ea6e69c1d208a92301423b2bc7584bc97
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 01 03:57:01 2017

Print Preview: Migrate remaining JS tests to use Mocha.

Migrating all remaining tests:

DuplexSettingsTrue
DuplexSettingsFalse
PrinterChangeUpdatesPreview
NoPDFPluginErrorMessage
CustomPaperNames
AdvancedSettings1Option
AdvancedSettings2Options
InitIssuesOneRequest
InvalidSettingsError
GenerateDraft

BUG= 726536 

Review-Url: https://codereview.chromium.org/2920593002
Cr-Commit-Position: refs/heads/master@{#476182}

[modify] https://crrev.com/87c1fd7ea6e69c1d208a92301423b2bc7584bc97/chrome/test/data/webui/BUILD.gn
[delete] https://crrev.com/0c284454162c7b36d587707af42828f41336904f/chrome/test/data/webui/print_preview/print_preview.js
[modify] https://crrev.com/87c1fd7ea6e69c1d208a92301423b2bc7584bc97/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/87c1fd7ea6e69c1d208a92301423b2bc7584bc97/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js

Comment 5 by dpa...@chromium.org, Jun 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment