New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726527 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: May 2017
Cc:
cl...@chromium.org
█ k...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Suggestions content flashes when transitioning to CH content

Project Member Reported by mdjones@chromium.org, May 25 2017 
Repro:

1. Focus omnibox from Chrome Home peek state.
2. Tap on some bottom navigation that isn't 'home'.
3. Suggestions content appears before the correct content.
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3df878ef6c01067a8446567be0a3b6b76416a6f6

commit 3df878ef6c01067a8446567be0a3b6b76416a6f6
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri May 26 16:14:26 2017

[Home] Fix suggestions flash

The bottom sheet no longer needs to show suggestions content if the
omnibox loses focus. The reasons for this are:

- The back button will close the sheet if the sheet was opened from
  the peek state.
- The 'home' button is available if the user wants to see the content.
- Moving the sheet transitions the content to suggestions.

This change removes the code that attempts to do this from
onOmniboxFocusChange.

BUG= 726527 

Change-Id: Ie2041413c45ec180a22db492be969e30273de679
Reviewed-on: https://chromium-review.googlesource.com/516526
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475024}
[modify] https://crrev.com/3df878ef6c01067a8446567be0a3b6b76416a6f6/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java

Comment 2 by mdjones@chromium.org, May 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment