New issue
Advanced search Search tips

Issue 726510 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-06-15
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 634270

Blocking:
issue 674593



Sign in to add a comment

Apply [SecureContext] to StorageManager

Project Member Reported by jsb...@chromium.org, May 25 2017

Issue description

third_party/WebKit/Source/modules/quota/StorageManager.idl has:

// TODO(jsbell): Should have [SecureContext] on interface

Which is true. Right now we don't support it on interfaces. Instead we rely on the `navigator.storage` attribute being [SecureContext] and thus the interface being useless.

https://chromium-review.googlesource.com/c/508328/ should unblock this soon.

The change afterwards is basically to add the attribute to the IDL and update global-interface-listings everywhere.

Optionally, we could also split NavigatorStorageQuota.idl's `partial interface Navigator` and mark the one with `readonly attribute StorageManager storage` but that should not be a webexposed change.



 
The NextAction date has arrived: 2017-06-01
NextAction: 2017-06-15
The NextAction date has arrived: 2017-06-15

Comment 4 by jsb...@chromium.org, Jul 28 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/576868c502837520ef386029cf19f06e4e95a240

commit 576868c502837520ef386029cf19f06e4e95a240
Author: Joshua Bell <jsbell@chromium.org>
Date: Fri Dec 01 20:50:30 2017

Apply [SecureContext] to StorageManager

The [SecureContext] extended attribute now applies correctly to
interfaces, so make sure that the StorageManager interface is not
exposed in non-secure contexts, not just the `navigator.storage` entry
point.

Bug:  726510 
Change-Id: Ie141aa4e29e261f1107af292f74f8063370c3748
Reviewed-on: https://chromium-review.googlesource.com/802676
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521056}
[modify] https://crrev.com/576868c502837520ef386029cf19f06e4e95a240/third_party/WebKit/Source/modules/quota/StorageManager.idl

Status: Fixed (was: Started)

Sign in to add a comment