+multiple for work on a related issue.

Related issue:  crbug.com/709117 

+wjmaclean for triage/reassigning.

I can reproduce this. Console output from a login attempt shown below:

[38345:775:0526/094347.587132:INFO:CONSOLE(2572)] "Uncaught TypeError: a.match is not a function", source: https://accounts.google.com/ServiceLogin?skipvpage=true&sarp=1&rm=hide&continue=chrome-extension%3A%2F%2Fmfffpogegjflfpflabcdkioaeobkgjik%2Fsuccess.html%3Faccess_point%3D17%26source%3D13&service=chromiumsync&hl=en-US (2572)
[38345:775:0526/094347.588111:INFO:CONSOLE(2572)] "Uncaught TypeError: a.match is not a function", source: https://accounts.google.com/ServiceLogin?skipvpage=true&sarp=1&rm=hide&continue=chrome-extension%3A%2F%2Fmfffpogegjflfpflabcdkioaeobkgjik%2Fsuccess.html%3Faccess_point%3D17%26source%3D13&service=chromiumsync&hl=en-US (2572)
[38345:47627:0526/094348.915960:WARNING:notification_platform_bridge_mac.mm(508)] AlertNotificationService: XPC connection interrupted.
[38345:775:0526/094414.810124:INFO:CONSOLE(2688)] "Credentials sent", source: https://accounts.google.com/ServiceLogin?skipvpage=true&sarp=1&rm=hide&continue=chrome-extension%3A%2F%2Fmfffpogegjflfpflabcdkioaeobkgjik%2Fsuccess.html%3Faccess_point%3D17%26source%3D13&service=chromiumsync&hl=en-US (2688)
[38345:775:0526/094415.180259:WARNING:CONSOLE(2358)] "Authenticator: No password scraped for SAML.", source: chrome://chrome-signin/gaia_auth_host.js (2358)
[38345:775:0526/094415.238038:WARNING:gaia_auth_fetcher.cc(724)] ClientLogin failed with 
[38345:775:0526/094415.238130:WARNING:gaia_auth_fetcher.cc(745)] Incomprehensible response from Google Accounts servers.
[38354:775:0526/094415.978427:ERROR:render_process_impl.cc(171)] WebFrame LEAKED 1 TIMES
[38345:775:0526/094416.019191:INFO:CONSOLE(6)] "SW registered", source: https://www.google.ca/_/chrome/newtab?espv=2&ie=UTF-8 (6)
[38345:775:0526/094416.794689:ERROR:CONSOLE(1)] "Uncaught ReferenceError: inline is not defined", source:  (1)

This looks like it is related to the 

ugh ... that got sent before I was done ...

This looks related to the previous issue, and to gaia signin-in in general, and/or the login extension, so I'm assigning it to msarda@ for triage. Adding in extensions folks also.

1. Did you set the API keys (client ID and secret) as explained here: https://www.chromium.org/developers/how-tos/api-keys ?


I think there is an issue with the test API keys that were not whitelisted on the server. Is teh sign-in working if you are using the sign-in from from settings (open chrome://settings and tap on the Sign in to Chromium)?

I just tried the sign-in from the settings page. It still fails, although silently (i.e. without showing the dialog). But the console log messages look the same.

Did you set the API keys (client ID and secret) as explained here: https://www.chromium.org/developers/how-tos/api-keys ?

No ... I've never run into that before.

If that's the problem, then perhaps we should provide a more meaningful message to the user?

Tested back to 56.0.2924.99, with the same behavior. Suspecting API keys is the issue.

Ok, it looks like my comment from earlier today was not submitted.

I tested this on ToT today and everything is working fine. The problem were most probably the API keys. Note that Chromium does show a special infobar when started without the API keys saying that some features will not be available (that includes sign-in). It is not clear to me if we want to do additional messaging for sign-in.

For Googlers: chrome://chrome-signin is using a special internal endpoint that requires whitelisting, and the internal testing client ID was not correctly whitelisted. This is now fixed.

I'm curious: I just went back and tested again on a Chromium build (on Mac), on an internal machine; I got no info bar regarding starting without API keys (nor any console info/error message), but still logging in from either chrome://chrome-signin or the settings page failed. Is this expected then?

When I try a ToT build on linux, the signin page also fails (and no infobar), but signing in via the settings page works.

On ToT+mac, I made sure the keys were installed. Not sure if it was a key problem on my end or not, but I suspect not.

 Issue 723862  has been merged into this issue.