New issue
Advanced search Search tips

Issue 726477 link

Starred by 1 user
Status: Verified
Owner:
eugene...@chromium.org
Closed: May 2017
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Network activity indicator does not stop after NTP reload

Project Member Reported by eugene...@chromium.org, May 25 2017 
App Version (from "Chrome Settings > About Chrome"): 60.0.3110.0 Canary
iOS Version: 10.3.1
Device: iPhone only

Steps to reproduce:
1.) Open NTP
2.) Open Tools Menu
3.) Tap Reload 

Observed behavior: 
Network activity indicator starts spinning and does not stop

Expected behavior: 
Network activity indicator should stop spinning
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8342ede4675b43769aa85569ee216e63b0efa39b

commit 8342ede4675b43769aa85569ee216e63b0efa39b
Author: eugenebut <eugenebut@chromium.org>
Date: Tue May 30 15:01:24 2017

Call WebStateObserver::DidStopLoading for native content reloads.

This has regressed after https://codereview.chromium.org/2902083003/

BUG= 726477 

Review-Url: https://codereview.chromium.org/2910663002
Cr-Commit-Position: refs/heads/master@{#475525}

[modify] https://crrev.com/8342ede4675b43769aa85569ee216e63b0efa39b/ios/web/web_state/navigation_callbacks_inttest.mm
[modify] https://crrev.com/8342ede4675b43769aa85569ee216e63b0efa39b/ios/web/web_state/ui/crw_web_controller.mm

Comment 2 by eugene...@chromium.org, May 30 2017

Labels: Merge-Request-60
Status: Fixed (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, May 30 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc77f39ceb69538ec88a8ee668a749d15e5e8780

commit cc77f39ceb69538ec88a8ee668a749d15e5e8780
Author: Eugene But <eugenebut@google.com>
Date: Tue May 30 16:49:47 2017

Call WebStateObserver::DidStopLoading for native content reloads.

This has regressed after https://codereview.chromium.org/2902083003/

BUG= 726477 

Review-Url: https://codereview.chromium.org/2910663002
Cr-Original-Commit-Position: refs/heads/master@{#475525}
Review-Url: https://codereview.chromium.org/2912993002 .
Cr-Commit-Position: refs/branch-heads/3112@{#32}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/cc77f39ceb69538ec88a8ee668a749d15e5e8780/ios/web/web_state/navigation_callbacks_inttest.mm
[modify] https://crrev.com/cc77f39ceb69538ec88a8ee668a749d15e5e8780/ios/web/web_state/ui/crw_web_controller.mm

Comment 5 by subhashi...@chromium.org, Jun 7 2017

Status: Verified (was: Fixed)
Verified this issue on:

App Version: 61.0.3123.0 canary
Device: iPhone 5S, iPhone 6 Plus
iOS Version: 10.2.1, 10.3.1

Issue is fixed. When the NTP is reloaded, network activity indicator is not even visible. Hence marking this issue as 'Verified'.

Comment 6 by subhashi...@chromium.org, Jun 7 2017 

Verified this issue on:

App Version: 60.0.3112.20 canary
Device: iPhone 6 Plus
iOS Version: 10.3.1

Issue is fixed. When the NTP is reloaded, network activity indicator is not even visible. Hence marking this issue as 'Verified'.
►

Sign in to add a comment