Let's see if we can do this for 60. If we can't make it, I'll do that for 61.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0827cd5289824410906172f4852f5f7e308d505c commit 0827cd5289824410906172f4852f5f7e308d505c Author: oshima <oshima@chromium.org> Date: Fri May 26 06:26:56 2017 Rename MaximizeMode to TabletMode renamed * maximize_mode_xxx files to tablet_mode_xxx * Class name MaximizeModeXxx to TabletModeXxx * variable names maximize_mode(xxx) to tablet_mode(xxx) * comments "maximize mode" to "tablet mode" BUG= 726476 R=skuhne@chromium.org, sky@chromium.org, reveman@chromium.org TEST=None Review-Url: https://codereview.chromium.org/2906803002 Cr-Commit-Position: refs/heads/master@{#474940} [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/BUILD.gn [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/accelerators/debug_commands.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/aura/shell_port_classic.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/aura/shell_port_classic.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/display/display_manager_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/frame/caption_buttons/frame_caption_button_container_view.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/frame/header_view.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/frame/header_view.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/metrics/pointer_metrics_recorder.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/metrics/pointer_metrics_recorder_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/mojo_interface_factory.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/mus/bridge/shell_port_mash.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/mus/bridge/shell_port_mash.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/shell.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/shell.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/shell_observer.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/shell_port.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/brightness/tray_brightness.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/brightness/tray_brightness_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/overview/overview_button_tray.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/overview/overview_button_tray.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/power/tablet_power_button_controller.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/power/tablet_power_button_controller.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/rotation/tray_rotation_lock.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/rotation/tray_rotation_lock.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/rotation/tray_rotation_lock_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/screen_layout_observer.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/system/screen_layout_observer_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/test/shell_test_api.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/virtual_keyboard_controller.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/lock_state_controller_unittest.cc [delete] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.cc [delete] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.h [delete] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/ash/wm/maximize_mode/maximize_mode_event_handler.h [delete] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/ash/wm/maximize_mode/maximize_mode_event_handler_aura.h [delete] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/power_button_controller.cc [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/OWNERS [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/accelerometer_test_data_literals.cc [add] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard.h [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_x11.h [add] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_backdrop_delegate_impl.cc [add] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_backdrop_delegate_impl.h [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_controller.cc [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_controller.h [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_event_handler.cc [add] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_event_handler.h [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_event_handler_aura.cc [add] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_event_handler_aura.h [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_window_manager.cc [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_window_manager.h [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_window_state.cc [rename] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/tablet_mode/tablet_mode_window_state.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/window_positioner.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/window_properties.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/window_state.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/keyboard.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/keyboard.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/shell_surface.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/wayland/server.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/wm_helper.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/wm_helper.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/wm_helper_ash.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/wm_helper_ash.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/wm_helper_mus.cc [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/components/exo/wm_helper_mus.h [modify] https://crrev.com/0827cd5289824410906172f4852f5f7e308d505c/testing/buildbot/filters/ash_unittests_mus.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/341337af9e7325e850cedacec0e9da958765dd83 commit 341337af9e7325e850cedacec0e9da958765dd83 Author: oshima <oshima@chromium.org> Date: Fri May 26 23:34:23 2017 Revert of Rename MaximizeMode to TabletMode (patchset #3 id:80001 of https://codereview.chromium.org/2906803002/ ) Reason for revert: Failed to be landed before branch cut. I'll try again before 61 cut. Original issue's description: > Rename MaximizeMode to TabletMode > > renamed > * maximize_mode_xxx files to tablet_mode_xxx > * Class name MaximizeModeXxx to TabletModeXxx > * variable names maximize_mode(xxx) to tablet_mode(xxx) > * comments "maximize mode" to "tablet mode" > > BUG= 726476 > R=skuhne@chromium.org, sky@chromium.org, reveman@chromium.org > TEST=None > > Review-Url: https://codereview.chromium.org/2906803002 > Cr-Commit-Position: refs/heads/master@{#474940} > Committed: https://chromium.googlesource.com/chromium/src/+/0827cd5289824410906172f4852f5f7e308d505c TBR=reveman@chromium.org,skuhne@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 726476 Review-Url: https://codereview.chromium.org/2909763002 Cr-Commit-Position: refs/heads/master@{#475187} [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/BUILD.gn [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/accelerators/debug_commands.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/aura/shell_port_classic.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/aura/shell_port_classic.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/display/display_manager_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/frame/caption_buttons/frame_caption_button_container_view.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/frame/header_view.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/frame/header_view.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/metrics/pointer_metrics_recorder.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/metrics/pointer_metrics_recorder_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/mojo_interface_factory.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/mus/bridge/shell_port_mash.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/mus/bridge/shell_port_mash.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/shell.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/shell.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/shell_observer.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/shell_port.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/brightness/tray_brightness.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/brightness/tray_brightness_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/overview/overview_button_tray.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/overview/overview_button_tray.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/power/tablet_power_button_controller.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/power/tablet_power_button_controller.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/rotation/tray_rotation_lock.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/rotation/tray_rotation_lock.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/rotation/tray_rotation_lock_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/screen_layout_observer.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/system/screen_layout_observer_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/test/shell_test_api.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/virtual_keyboard_controller.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/lock_state_controller_unittest.cc [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/OWNERS [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/accelerometer_test_data_literals.cc [add] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.cc [add] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.h [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_controller.cc [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_controller.h [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_event_handler.cc [add] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_event_handler.h [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_event_handler_aura.cc [add] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_event_handler_aura.h [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_window_manager.cc [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_window_manager.h [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_window_state.cc [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/maximize_mode_window_state.h [add] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard.h [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc [rename] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/power_button_controller.cc [delete] https://crrev.com/ae7cd2d737112818ef88c1167c816e171e2e4623/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard.h [delete] https://crrev.com/ae7cd2d737112818ef88c1167c816e171e2e4623/ash/wm/tablet_mode/tablet_mode_backdrop_delegate_impl.cc [delete] https://crrev.com/ae7cd2d737112818ef88c1167c816e171e2e4623/ash/wm/tablet_mode/tablet_mode_backdrop_delegate_impl.h [delete] https://crrev.com/ae7cd2d737112818ef88c1167c816e171e2e4623/ash/wm/tablet_mode/tablet_mode_event_handler.h [delete] https://crrev.com/ae7cd2d737112818ef88c1167c816e171e2e4623/ash/wm/tablet_mode/tablet_mode_event_handler_aura.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/window_positioner.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/window_properties.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/window_state.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/keyboard.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/keyboard.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/shell_surface.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/wayland/server.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/wm_helper.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/wm_helper.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/wm_helper_ash.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/wm_helper_ash.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/wm_helper_mus.cc [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/components/exo/wm_helper_mus.h [modify] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/testing/buildbot/filters/ash_unittests_mus.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51 commit 0e9b7a67ce59357139a4d354e4fcf3ee1913cb51 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Jul 19 18:23:03 2017 Rename MaximizeMode to TabletMode This is m61 version of last attempt: https://codereview.chromium.org/2906803002/ renamed * maximize_mode_xxx files to tablet_mode_xxx * Class name MaximizeModeXxx to TabletModeXxx * variable names maximize_mode(xxx) to tablet_mode(xxx) * comments "maximize mode" to "tablet mode" BUG= 726476 R=skuhne@chromium.org, sky@chromium.org, reveman@chromium.org TBR=reveman@chromium.org TEST=None Rename MaximizeMode to TabletMode This is m61 version of last attempt: https://codereview.chromium.org/2906803002/ renamed * maximize_mode_xxx files to tablet_mode_xxx * Class name MaximizeModeXxx to TabletModeXxx * variable names maximize_mode(xxx) to tablet_mode(xxx) * comments "maximize mode" to "tablet mode" BUG= 726476 R=skuhne@chromium.org, sky@chromium.org, reveman@chromium.org TBR=reveman@chromium.org TEST=None Change-Id: I138134efe0b8af559d04c7682ee13b93e63cbbc6 Reviewed-on: https://chromium-review.googlesource.com/572945 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487922} [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/BUILD.gn [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/accelerators/debug_commands.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/app_list/app_list_presenter_delegate.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/aura/shell_port_classic.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/aura/shell_port_classic.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/display/display_manager_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/frame/caption_buttons/frame_caption_button_container_view.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/frame/header_view.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/frame/header_view.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/metrics/pointer_metrics_recorder.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/metrics/pointer_metrics_recorder_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/mojo_interface_factory.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/mus/bridge/shell_port_mash.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/mus/bridge/shell_port_mash.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/rotator/screen_rotation_animator_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/shell.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/shell.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/shell_observer.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/shell_port.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/shell_test_api.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/brightness/tray_brightness.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/brightness/tray_brightness_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/keyboard_brightness/tray_keyboard_brightness.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/keyboard_brightness/tray_keyboard_brightness_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/overview/overview_button_tray.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/overview/overview_button_tray.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/power/tablet_power_button_controller.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/power/tablet_power_button_controller.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/rotation/tray_rotation_lock.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/rotation/tray_rotation_lock.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/rotation/tray_rotation_lock_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/screen_layout_observer.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/screen_layout_observer_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/tray/system_tray.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/tray/system_tray_bubble.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/tray/system_tray_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/tray/tray_background_view.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/tray/tray_event_filter.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/system/tray_drag_controller.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/virtual_keyboard_controller.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/lock_state_controller_unittest.cc [delete] https://crrev.com/426db7347f7ffe64a537fa122c27dec38fe88340/ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.cc [delete] https://crrev.com/426db7347f7ffe64a537fa122c27dec38fe88340/ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.h [delete] https://crrev.com/426db7347f7ffe64a537fa122c27dec38fe88340/ash/wm/maximize_mode/maximize_mode_event_handler.h [delete] https://crrev.com/426db7347f7ffe64a537fa122c27dec38fe88340/ash/wm/maximize_mode/maximize_mode_event_handler_aura.h [delete] https://crrev.com/426db7347f7ffe64a537fa122c27dec38fe88340/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/power_button_controller.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/splitview/split_view_controller.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/OWNERS [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/accelerometer_test_data_literals.cc [add] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_x11.h [add] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_backdrop_delegate_impl.cc [add] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_backdrop_delegate_impl.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_controller.cc [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_controller.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_event_handler.cc [add] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_event_handler.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_event_handler_aura.cc [add] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_event_handler_aura.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_window_manager.cc [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_window_manager.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_window_state.cc [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/tablet_mode_window_state.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/touchpad_and_keyboard_disabler.cc [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/touchpad_and_keyboard_disabler.h [rename] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/tablet_mode/touchpad_and_keyboard_disabler_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/window_positioner.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/window_properties.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/window_state.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/ash/launcher/launcher_context_menu.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/frame/glass_browser_frame_view.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/keyboard.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/keyboard.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/keyboard_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/shell_surface.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/wayland/server.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/wm_helper.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/wm_helper.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/wm_helper_ash.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/wm_helper_ash.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/wm_helper_mus.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/components/exo/wm_helper_mus.h [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/testing/buildbot/filters/ash_unittests_mash.filter [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/testing/buildbot/filters/ash_unittests_mus.filter [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/0e9b7a67ce59357139a4d354e4fcf3ee1913cb51/ui/app_list/views/app_list_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63d3f2ad497cc2e183f2882c45bca5b543831afe commit 63d3f2ad497cc2e183f2882c45bca5b543831afe Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Aug 23 00:12:11 2017 Rename TouchView to TabletMode No changes to strings that may be used as flag values, metrics, as they're already used. BUG: 726476 Change-Id: I91588f2bca5ceb100abdf10b5c2be2f2b2b0c979 Reviewed-on: https://chromium-review.googlesource.com/577380 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#496518} [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/accelerators/accelerator_table.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/accelerators/accelerator_table.h [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/accelerators/debug_commands.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/ash_switches.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/ash_switches.h [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/display/screen_ash.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/metrics/pointer_metrics_recorder.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/mojo_interface_factory.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/public/interfaces/BUILD.gn [rename] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/public/interfaces/tablet_mode.mojom [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/system/ime_menu/ime_list_view.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/system/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/wm/session_state_animator.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/wm/tablet_mode/tablet_mode_controller.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/wm/tablet_mode/tablet_mode_controller.h [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/chrome/browser/about_flags.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/chrome/browser/flag_descriptions.h [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ui/login/account_picker/md_screen_account_picker.js [modify] https://crrev.com/63d3f2ad497cc2e183f2882c45bca5b543831afe/ui/login/account_picker/screen_account_picker.js
Thank you for doing this. It makes the code much clearer.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bbb867d4e825ab4229ff1d5dccd4780e3c23c59 commit 0bbb867d4e825ab4229ff1d5dccd4780e3c23c59 Author: Wenzhao Zang <wzang@chromium.org> Date: Tue Aug 29 21:45:22 2017 Rename TouchView to TabletMode in user_pod_row.js This is a follow-up to CL 577380. Bug: 726476 Change-Id: I870d69800cbb504044c78dd858985291e106b995 Reviewed-on: https://chromium-review.googlesource.com/641977 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#498238} [modify] https://crrev.com/0bbb867d4e825ab4229ff1d5dccd4780e3c23c59/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/0bbb867d4e825ab4229ff1d5dccd4780e3c23c59/ui/login/account_picker/user_pod_row.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1576e6f0c9c54714d01ad98fcb850d043a473c80 commit 1576e6f0c9c54714d01ad98fcb850d043a473c80 Author: Sammie Quon <sammiequon@google.com> Date: Thu Aug 31 20:52:13 2017 mash: Update manifests touchview -> tabletmode. These two files were missed by the mojo touch view manager to tablet mode manager transition. May cause issues with signin. Test: manual, enter login page and verify "Connection InterfaceProvideSpec prevented service content_browser from binding interface: ash::mojom::TabletModeManager exposed by:ash " does not appear Bug: 726476 Change-Id: I3e1ee3c7e3bad0303fe03739e54e2a93ec4de145 Reviewed-on: https://chromium-review.googlesource.com/646076 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#498990} [modify] https://crrev.com/1576e6f0c9c54714d01ad98fcb850d043a473c80/ash/mus/manifest.json [modify] https://crrev.com/1576e6f0c9c54714d01ad98fcb850d043a473c80/ash/mus/standalone/manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03c32b144e3792321ed95ba7160e2c2e548cc74c commit 03c32b144e3792321ed95ba7160e2c2e548cc74c Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Apr 25 00:35:31 2018 Revert wrong maximized->tablet comment changes Bug: 726476 Change-Id: Ifdbb411cc622ae29d38778030aa755bcc38eec2e Reviewed-on: https://chromium-review.googlesource.com/1026849 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#553391} [modify] https://crrev.com/03c32b144e3792321ed95ba7160e2c2e548cc74c/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/03c32b144e3792321ed95ba7160e2c2e548cc74c/chrome/browser/ui/views/frame/glass_browser_frame_view.h [modify] https://crrev.com/03c32b144e3792321ed95ba7160e2c2e548cc74c/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc [modify] https://crrev.com/03c32b144e3792321ed95ba7160e2c2e548cc74c/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc [modify] https://crrev.com/03c32b144e3792321ed95ba7160e2c2e548cc74c/chrome/browser/ui/views/toolbar/toolbar_view.cc
Comment 1 by osh...@chromium.org
, May 25 2017